api/client: various (MenuEntry api stuff, agility/translate plugin stuff to use that) (#1748)

* Standardize MenuEntry methods, make MenuEntry events extend MenuEntry

* Make agility plugin only change entries it needs to

* Clean up chat translator by a lot, also implement cloneable instead of just adding a ranodm copy method smh

* actions: allow slash in PR title

* devtools: Fix checkstyle

* examineplugin: Fix tests
This commit is contained in:
Lucwousin
2019-10-11 12:05:45 +02:00
committed by Kyle
parent 537eb29538
commit 85f266c181
41 changed files with 507 additions and 480 deletions

View File

@@ -89,7 +89,7 @@ public class ExaminePluginTest
{
when(client.getWidget(anyInt(), anyInt())).thenReturn(mock(Widget.class));
MenuOptionClicked menuOptionClicked = new MenuOptionClicked(new MenuEntry(
MenuOptionClicked menuOptionClicked = new MenuOptionClicked(
"Examine",
"Something",
ItemID.ABYSSAL_WHIP,
@@ -97,7 +97,7 @@ public class ExaminePluginTest
123,
456,
false
));
);
examinePlugin.onMenuOptionClicked(menuOptionClicked);
ChatMessage chatMessage = new ChatMessage(null, ChatMessageType.ITEM_EXAMINE, "", "A weapon from the abyss.", "", 0);
@@ -112,7 +112,7 @@ public class ExaminePluginTest
{
when(client.getWidget(anyInt(), anyInt())).thenReturn(mock(Widget.class));
MenuOptionClicked menuOptionClicked = new MenuOptionClicked(new MenuEntry(
MenuOptionClicked menuOptionClicked = new MenuOptionClicked(
"Examine",
"Something",
ItemID.ABYSSAL_WHIP,
@@ -120,8 +120,7 @@ public class ExaminePluginTest
123,
456,
false
));
);
examinePlugin.onMenuOptionClicked(menuOptionClicked);
@@ -130,4 +129,4 @@ public class ExaminePluginTest
verify(examineClient, never()).submitItem(anyInt(), anyString());
}
}
}