From 85264649db3d79ccba12e92be69ca05b9d0a4f19 Mon Sep 17 00:00:00 2001 From: sdburns1998 Date: Sun, 7 Jul 2019 18:00:14 +0200 Subject: [PATCH] pvptools: Final fields --- .../plugins/pvptools/PlayerCountOverlay.java | 2 +- .../plugins/pvptools/PvpToolsOverlay.java | 2 +- .../plugins/pvptools/PvpToolsPanel.java | 24 +++++++++---------- .../plugins/pvptools/PvpToolsPlugin.java | 2 +- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PlayerCountOverlay.java b/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PlayerCountOverlay.java index a620a6d8aa..389c553af8 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PlayerCountOverlay.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PlayerCountOverlay.java @@ -32,7 +32,7 @@ import org.apache.commons.lang3.ArrayUtils; @Singleton public class PlayerCountOverlay extends Overlay { - private static int[] CLAN_WARS_REGIONS = {9520, 13135, 13134, 13133, 13131, 13130, 13387, 13386}; + private static final int[] CLAN_WARS_REGIONS = {9520, 13135, 13134, 13133, 13131, 13130, 13387, 13386}; private final PvpToolsPlugin pvpToolsPlugin; private final Client client; diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsOverlay.java b/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsOverlay.java index 09e0cccdf1..5b8a3f7f1c 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsOverlay.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsOverlay.java @@ -25,7 +25,7 @@ import net.runelite.client.ui.overlay.OverlayUtil; @Singleton public class PvpToolsOverlay extends Overlay { - private PvpToolsPlugin pvpToolsPlugin; + private final PvpToolsPlugin pvpToolsPlugin; @Inject private PvpToolsOverlay(final PvpToolsPlugin pvpToolsPlugin) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPanel.java b/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPanel.java index b412c1a22e..c64dacff12 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPanel.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPanel.java @@ -34,18 +34,18 @@ class PvpToolsPanel extends PluginPanel private final JLabel loggedLabel = new JLabel(); private final JRichTextPane emailLabel = new JRichTextPane(); - JLabel numCC = new JLabel(); - JLabel numOther = new JLabel(); - JLabel numMageJLabel = new JLabel(" "); - JLabel numRangeJLabel = new JLabel(" "); - JLabel numMeleeJLabel = new JLabel(" "); - JLabel totalRiskLabel = new JLabel(" "); - JLabel riskProtectingItem = new JLabel(" "); - JLabel biggestItemLabel = new JLabel("Protected Item: "); - JButton missingPlayers = new JButton("Show missing CC members"); - JButton currentPlayers = new JButton("Show current CC members"); - private JLabel numBrews = new JLabel(); - private JPanel missingPlayersPanel = new JPanel(); + final JLabel numCC = new JLabel(); + final JLabel numOther = new JLabel(); + final JLabel numMageJLabel = new JLabel(" "); + final JLabel numRangeJLabel = new JLabel(" "); + final JLabel numMeleeJLabel = new JLabel(" "); + final JLabel totalRiskLabel = new JLabel(" "); + final JLabel riskProtectingItem = new JLabel(" "); + final JLabel biggestItemLabel = new JLabel("Protected Item: "); + final JButton missingPlayers = new JButton("Show missing CC members"); + final JButton currentPlayers = new JButton("Show current CC members"); + private final JLabel numBrews = new JLabel(); + private final JPanel missingPlayersPanel = new JPanel(); public static String htmlLabel(String key, String value) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPlugin.java index ad858dccf8..c3bc84aef1 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/pvptools/PvpToolsPlugin.java @@ -97,7 +97,7 @@ public class PvpToolsPlugin extends Plugin @Inject private ItemManager itemManager; - private PvpToolsPlugin uhPvpToolsPlugin = this; + private final PvpToolsPlugin uhPvpToolsPlugin = this; /** * ActionListener for the missing cc members and refresh buttons