ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Do not reuse HttpUrl.builder for building xp urls

Browse Source 
Due to HttpUrl.Builder being mutable, this causes duplicate URL path
segments when tracking more than 1 skill at a time.

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
This commit is contained in:
Tomas Slusny
2018-04-13 16:04:58 +02:00
parent aa96fc9f06
commit 81b8d2f664
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
runelite-client/src/main/java/net/runelite/client/plugins/xptracker/XpPanel.java
View File

@@ -49,12 +49,6 @@ import okhttp3.HttpUrl;
@Slf4j @Slf4j
class XpPanel extends PluginPanel class XpPanel extends PluginPanel
{ {
private static final HttpUrl.Builder XP_TRACKER_FORMAT = new HttpUrl.Builder()
.scheme("https")
.host("runelite.net")
.addPathSegment("xp")
.addPathSegment("show");
private final Map<Skill, XpInfoBox> infoBoxes = new HashMap<>(); private final Map<Skill, XpInfoBox> infoBoxes = new HashMap<>();
private final JLabel totalXpGained = new JLabel(); private final JLabel totalXpGained = new JLabel();
private final JLabel totalXpHr = new JLabel(); private final JLabel totalXpHr = new JLabel();
@@ -120,7 +114,11 @@ class XpPanel extends PluginPanel
return ""; return "";
} }
return XP_TRACKER_FORMAT return new HttpUrl.Builder()
.scheme("https")
.host("runelite.net")
.addPathSegment("xp")
.addPathSegment("show")
.addPathSegment(skill.getName().toLowerCase()) .addPathSegment(skill.getName().toLowerCase())
.addPathSegment(player.getName()) .addPathSegment(player.getName())
.addPathSegment("1week") .addPathSegment("1week")