ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

cache: fix trackloader sometmies producing corrupt midis

Browse Source 
OutputStream is free to internally resize its bytebuffer. Remove byte[] constructor to prevent misuse again.
This commit is contained in:
Adam
2017-06-04 19:42:26 -04:00
parent 0ef72eb878
commit 7e0a1c37d3
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cache/src/main/java/net/runelite/cache/definitions/loaders/TrackLoader.java vendored
View File

@@ -246,8 +246,7 @@ public class TrackLoader
var1.skip(var25); var1.skip(var25);
int var50 = var1.getOffset(); int var50 = var1.getOffset();
var1.skip(tempoOpcodes * 3); var1.skip(tempoOpcodes * 3);
def.midi = new byte[offset]; OutputStream var51 = new OutputStream(offset);
OutputStream var51 = new OutputStream(def.midi);
var51.writeInt(1297377380); // MThd header var51.writeInt(1297377380); // MThd header
var51.writeInt(6); // length of header var51.writeInt(6); // length of header
var51.writeShort(tracks > 1 ? 1 : 0); // format var51.writeShort(tracks > 1 ? 1 : 0); // format
@@ -457,5 +456,6 @@ public class TrackLoader
} }
} }
def.midi = var51.flip();
} }
} }

5
cache/src/main/java/net/runelite/cache/io/OutputStream.java vendored
View File

@@ -41,11 +41,6 @@ public final class OutputStream extends java.io.OutputStream
this(16); this(16);
} }
public OutputStream(byte[] b)
{
buffer = ByteBuffer.wrap(b);
}
public byte[] getArray() public byte[] getArray()
{ {
assert buffer.hasArray(); assert buffer.hasArray();