ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

skill calculator: Define actions and bonuses in Java

Browse Source 
As the number of bonus types increases, the existing system of allowing
only a single type of bonus to be applied, and only allowing actions to
entirely opt out of having bonuses applied rather than more fine-grained
control, is showing its age. This commit redefines all bonus and action
entries in Java enums so that such systems can be better-defined.
Additionally, it comes with the benefit of easier change validation via
testing and enabling item and sprite ID referencing via runelite-api.
This commit is contained in:
Jordan Atwood
2021-09-09 22:48:03 -07:00
committed by Adam
parent 6428a7af4f
commit 7b678b2afb
49 changed files with 2502 additions and 8227 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
runelite-client/src/test/java/net/runelite/client/plugins/skillcalculator/CalculatorTypeTest.java Normal file
View File

@@ -0,0 +1,51 @@
/*
* Copyright (c) 2021, Jordan Atwood <nightfirecat@protonmail.com>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice, this
* list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
* ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
package net.runelite.client.plugins.skillcalculator;
import net.runelite.client.plugins.skillcalculator.skills.SkillAction;
import static org.junit.Assert.fail;
import org.junit.Test;
public class CalculatorTypeTest
{
@Test
public void skillActionsInLevelOrder()
{
for (final CalculatorType calculatorType : CalculatorType.values())
{
int level = 1;
for (final SkillAction skillAction : calculatorType.getSkillActions())
{
if (skillAction.getLevel() < level)
{
fail("Skill action " + skillAction + " is out of order for " + calculatorType.getSkill().getName());
}
level = skillAction.getLevel();
}
}
}
}