ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

client: use item composition high alch price

Browse Source 
The correct way to compute ha price is floor(storePrice * 0.6f). This
was being computed incorrectly everywhere except for the bank plugin.
THis is now being computed centrally via the api.
This commit is contained in:
Adam
2020-06-27 12:21:21 -04:00
parent 5ab04030b8
commit 71d89af946
7 changed files with 19 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
runelite-client/src/test/java/net/runelite/client/plugins/bank/BankPluginTest.java
View File

@@ -84,8 +84,8 @@ public class BankPluginTest
ItemComposition comp = mock(ItemComposition.class);
// 60k HA price * 30 = 1.8m
when(comp.getPrice())
.thenReturn(100_000);
when(comp.getHaPrice())
.thenReturn(60_000);
// 400k GE Price * 30 = 12m
when(itemManager.getItemPrice(itemId))
@@ -121,8 +121,8 @@ public class BankPluginTest
).toArray(new Item[0]);
ItemComposition whipComp = mock(ItemComposition.class);
when(whipComp.getPrice())
.thenReturn(7); // 7 * .6 = 4, 4 * 1m overflows
when(whipComp.getHaPrice())
.thenReturn(4); // 4 * 1m overflows
when(itemManager.getItemComposition(ItemID.ABYSSAL_WHIP))
.thenReturn(whipComp);
when(itemManager.getItemPrice(ItemID.ABYSSAL_WHIP))