diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldHopperPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldHopperPlugin.java index b734ed491a..ea47ce5747 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldHopperPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldHopperPlugin.java @@ -228,6 +228,7 @@ public class WorldHopperPlugin extends Plugin private void clearFavoriteConfig(int world) { configManager.unsetConfiguration(WorldHopperConfig.GROUP, "favorite_" + world); + panel.resetAllFavoriteMenus(); } boolean isFavorite(World world) @@ -250,12 +251,14 @@ public class WorldHopperPlugin extends Plugin { log.debug("Adding world {} to favorites", world.getId()); setFavoriteConfig(world.getId()); + panel.updateFavoriteMenu(world.getId(), true); } void removeFromFavorites(World world) { log.debug("Removing world {} from favorites", world.getId()); clearFavoriteConfig(world.getId()); + panel.updateFavoriteMenu(world.getId(), false); } @Subscribe diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldSwitcherPanel.java b/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldSwitcherPanel.java index 537e2bf375..a7c2902f3d 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldSwitcherPanel.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldSwitcherPanel.java @@ -150,6 +150,26 @@ class WorldSwitcherPanel extends PluginPanel listContainer.repaint(); } + void updateFavoriteMenu(int world, boolean favorite) + { + for (WorldTableRow row : rows) + { + if (row.getWorld().getId() == world) + { + row.setFavoriteMenu(favorite); + } + } + } + + void resetAllFavoriteMenus() + { + for (WorldTableRow row : rows) + { + row.setFavoriteMenu(false); + } + + } + void populate(List worlds) { rows.clear(); diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldTableRow.java b/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldTableRow.java index e0182cb663..474669e95c 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldTableRow.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/worldhopper/WorldTableRow.java @@ -27,6 +27,7 @@ package net.runelite.client.plugins.worldhopper; import java.awt.BorderLayout; import java.awt.Color; import java.awt.Dimension; +import java.awt.event.ActionListener; import java.awt.event.MouseAdapter; import java.awt.event.MouseEvent; import java.util.function.BiConsumer; @@ -69,9 +70,12 @@ class WorldTableRow extends JPanel FLAG_GER = new ImageIcon(ImageUtil.getResourceStreamFromClass(WorldHopperPlugin.class, "flag_ger.png")); } + private final JMenuItem favoriteMenuOption = new JMenuItem(); + private JLabel worldField; private JLabel playerCountField; private JLabel activityField; + private BiConsumer onFavorite; @Getter private final World world; @@ -86,6 +90,7 @@ class WorldTableRow extends JPanel { this.current = current; this.world = world; + this.onFavorite = onFavorite; this.updatedPlayerCount = world.getPlayers(); setLayout(new BorderLayout()); @@ -137,19 +142,11 @@ class WorldTableRow extends JPanel } }); - String favoriteAction = favorite ? - "Remove " + world.getId() + " from favorites" : - "Add " + world.getId() + " to favorites"; - - final JMenuItem fav = new JMenuItem(favoriteAction); - fav.addActionListener(e -> - { - onFavorite.accept(world, !favorite); - }); + setFavoriteMenu(favorite); final JPopupMenu popupMenu = new JPopupMenu(); popupMenu.setBorder(new EmptyBorder(5, 5, 5, 5)); - popupMenu.add(fav); + popupMenu.add(favoriteMenuOption); setComponentPopupMenu(popupMenu); @@ -177,6 +174,25 @@ class WorldTableRow extends JPanel add(activityField, BorderLayout.CENTER); } + void setFavoriteMenu(boolean favorite) + { + String favoriteAction = favorite ? + "Remove " + world.getId() + " from favorites" : + "Add " + world.getId() + " to favorites"; + + favoriteMenuOption.setText(favoriteAction); + + for (ActionListener listener : favoriteMenuOption.getActionListeners()) + { + favoriteMenuOption.removeActionListener(listener); + } + + favoriteMenuOption.addActionListener(e -> + { + onFavorite.accept(world, !favorite); + }); + } + void updatePlayerCount(int playerCount) { this.updatedPlayerCount = playerCount;