From 6a1f9927e6b5ac758ce9a26da1d7f42431144475 Mon Sep 17 00:00:00 2001 From: Kyle <48519776+xKylee@users.noreply.github.com> Date: Thu, 4 Jun 2020 01:54:01 +0100 Subject: [PATCH] configmanager: log null defaults without crashing configmanager: log null defaults without crashing --- .../java/net/runelite/client/config/ConfigManager.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java b/runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java index 8c8c2ec704..60b9e1b7fd 100644 --- a/runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java +++ b/runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java @@ -753,6 +753,11 @@ public class ConfigManager } String current = getConfiguration(group.value(), item.keyName()); + if (defaultValue == null) + { + log.error("Plugin with bad default configuration, see config group {}, keyName {}", group.value(), item.keyName()); + continue; + } String valueString = objectToString(defaultValue); // null and the empty string are treated identically in sendConfig and treated as an unset // If a config value defaults to "" and the current value is null, it will cause an extra @@ -884,4 +889,4 @@ public class ConfigManager { return consumers.getOrDefault(configGroup + "." + keyName, (p) -> log.error("Failed to retrieve consumer with name {}.{}", configGroup, keyName)); } -} \ No newline at end of file +}