From be2118f3573121217b721cd834e3d8bcb77c5286 Mon Sep 17 00:00:00 2001 From: Ruben Amendoeira Date: Thu, 24 May 2018 20:18:48 +0100 Subject: [PATCH] Hiscore auto-complete fix Fixes #3202 When I refactored the IconTextField to include a new component called FlatTextField, I forgot to change the methods to add/remove key listeners. - All I had to do is override de addKeyListener/removeKeyListener methods on both the IconTextField and FlatTextField instead of some useless no-sense-making similar methods I had. Easy fix. --- .../client/plugins/hiscore/HiscorePanel.java | 4 ++-- .../runelite/client/ui/components/FlatTextField.java | 12 +++++++----- .../runelite/client/ui/components/IconTextField.java | 10 ++++++---- 3 files changed, 15 insertions(+), 11 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/hiscore/HiscorePanel.java b/runelite-client/src/main/java/net/runelite/client/plugins/hiscore/HiscorePanel.java index e5ef5648bf..88d6654347 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/hiscore/HiscorePanel.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/hiscore/HiscorePanel.java @@ -493,12 +493,12 @@ public class HiscorePanel extends PluginPanel void addInputKeyListener(KeyListener l) { - this.input.addInputKeyListener(l); + this.input.addKeyListener(l); } void removeInputKeyListener(KeyListener l) { - this.input.removeInputKeyListener(l); + this.input.removeKeyListener(l); } /* diff --git a/runelite-client/src/main/java/net/runelite/client/ui/components/FlatTextField.java b/runelite-client/src/main/java/net/runelite/client/ui/components/FlatTextField.java index e51de3481b..2ab50132e4 100644 --- a/runelite-client/src/main/java/net/runelite/client/ui/components/FlatTextField.java +++ b/runelite-client/src/main/java/net/runelite/client/ui/components/FlatTextField.java @@ -110,14 +110,16 @@ public class FlatTextField extends JPanel textField.setText(text); } - public void addInputKeyListener(KeyListener l) + @Override + public void addKeyListener(KeyListener keyListener) { - textField.addKeyListener(l); + textField.addKeyListener(keyListener); } - public void removeInputKeyListener(KeyListener l) + @Override + public void removeKeyListener(KeyListener keyListener) { - textField.removeKeyListener(l); + textField.removeKeyListener(keyListener); } @Override @@ -134,7 +136,7 @@ public class FlatTextField extends JPanel } super.setBackground(color); - + if (saveColor) { this.backgroundColor = color; diff --git a/runelite-client/src/main/java/net/runelite/client/ui/components/IconTextField.java b/runelite-client/src/main/java/net/runelite/client/ui/components/IconTextField.java index f9f84d87b2..229dab15cb 100644 --- a/runelite-client/src/main/java/net/runelite/client/ui/components/IconTextField.java +++ b/runelite-client/src/main/java/net/runelite/client/ui/components/IconTextField.java @@ -145,14 +145,16 @@ public class IconTextField extends JPanel this.textField.setHoverBackgroundColor(hoverBackgroundColor); } - public void addInputKeyListener(KeyListener l) + @Override + public void addKeyListener(KeyListener keyListener) { - textField.addKeyListener(l); + textField.addKeyListener(keyListener); } - public void removeInputKeyListener(KeyListener l) + @Override + public void removeKeyListener(KeyListener keyListener) { - textField.removeKeyListener(l); + textField.removeKeyListener(keyListener); } public void setEditable(boolean editable)