diff --git a/runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java b/runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java index 42a6d4e965..93510dc94a 100644 --- a/runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java +++ b/runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java @@ -78,6 +78,7 @@ import javax.annotation.Nullable; import javax.inject.Inject; import javax.inject.Named; import javax.inject.Singleton; +import lombok.NonNull; import lombok.extern.slf4j.Slf4j; import net.runelite.api.Client; import net.runelite.api.Player; @@ -482,7 +483,7 @@ public class ConfigManager setConfiguration(groupName, null, key, value); } - public void setConfiguration(String groupName, String profile, String key, String value) + public void setConfiguration(String groupName, String profile, String key, @NonNull String value) { if (Strings.isNullOrEmpty(groupName) || Strings.isNullOrEmpty(key)) { diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/slayer/SlayerPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/slayer/SlayerPlugin.java index 24816d559e..bc9281980e 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/slayer/SlayerPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/slayer/SlayerPlugin.java @@ -316,7 +316,14 @@ public class SlayerPlugin extends Plugin private void setProfileConfig(String key, Object value) { - configManager.setRSProfileConfiguration(SlayerConfig.GROUP_NAME, key, value); + if (value != null) + { + configManager.setRSProfileConfiguration(SlayerConfig.GROUP_NAME, key, value); + } + else + { + configManager.unsetRSProfileConfiguration(SlayerConfig.GROUP_NAME, key); + } } private void save() diff --git a/runelite-client/src/test/java/net/runelite/client/plugins/slayer/SlayerPluginTest.java b/runelite-client/src/test/java/net/runelite/client/plugins/slayer/SlayerPluginTest.java index 21af0f0538..f10e525ce8 100644 --- a/runelite-client/src/test/java/net/runelite/client/plugins/slayer/SlayerPluginTest.java +++ b/runelite-client/src/test/java/net/runelite/client/plugins/slayer/SlayerPluginTest.java @@ -553,6 +553,8 @@ public class SlayerPluginTest assertEquals("", slayerPlugin.getTaskName()); assertEquals(0, slayerPlugin.getAmount()); + + verify(configManager).unsetRSProfileConfiguration(SlayerConfig.GROUP_NAME, SlayerConfig.TASK_LOC_KEY); } @Test