From 4f0ba60f016ed2ba9fd8fbce6955c285e3f0d32b Mon Sep 17 00:00:00 2001 From: ThatGamerBlue Date: Sun, 7 Jul 2019 22:11:29 +0100 Subject: [PATCH 1/3] npcunaggroarea: make the notifications respect the config --- .../client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java index af60fb56ed..fd8d2312f4 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java @@ -521,6 +521,10 @@ public class NpcAggroAreaPlugin extends Plugin void doNotification() { + if(!this.sendNotification) + { + return; + } if (hasSentNotification) { return; From 459198cdf0e6b5aa5c46afff3262529aaac5feb0 Mon Sep 17 00:00:00 2001 From: ThatGamerBlue Date: Sun, 7 Jul 2019 22:12:22 +0100 Subject: [PATCH 2/3] guard clauses should have a newline after them --- .../client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java index fd8d2312f4..f2c14bb0cd 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java @@ -525,10 +525,12 @@ public class NpcAggroAreaPlugin extends Plugin { return; } + if (hasSentNotification) { return; } + final Player local = client.getLocalPlayer(); hasSentNotification = true; notifier.notify("[" + local.getName() + "]'s aggression timer has run out!"); From 9b44123fd3ab0c91abccb9aab41e3d6ebd070056 Mon Sep 17 00:00:00 2001 From: ThatGamerBlue Date: Sun, 7 Jul 2019 22:21:25 +0100 Subject: [PATCH 3/3] i would force-push this but im using github web --- .../client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java index f2c14bb0cd..f9053cc2dd 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/npcunaggroarea/NpcAggroAreaPlugin.java @@ -521,7 +521,7 @@ public class NpcAggroAreaPlugin extends Plugin void doNotification() { - if(!this.sendNotification) + if (!this.sendNotification) { return; }