rs-client: Cleanup (#1087)

* rs-client: name SpriteBuffer

* rs-client: (re)name spritebuffer methods

* rs-client/deob: Add missed @Export's, make updatemappings fix this next time

* rs-client: run intellij redundant else inspection

* rs-client: invert some script interpreter if's

* deob: checkstyle fixes

* rs-client: SpriteBuffer_loadSprite -> SpriteBuffer_bufferFile
This commit is contained in:
Lucwousin
2019-07-23 19:43:31 +02:00
committed by GitHub
parent 61b4531a0d
commit 596689a4f7
175 changed files with 9825 additions and 9776 deletions

View File

@@ -95,40 +95,49 @@ public class class83 {
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETCOLOUR) {
}
if (var0 == ScriptOpcodes.CC_SETCOLOUR) {
var3.color = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETFILL) {
}
if (var0 == ScriptOpcodes.CC_SETFILL) {
var3.fill = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETTRANS) {
}
if (var0 == ScriptOpcodes.CC_SETTRANS) {
var3.transparencyTop = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETLINEWID) {
}
if (var0 == ScriptOpcodes.CC_SETLINEWID) {
var3.lineWid = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETGRAPHIC) {
}
if (var0 == ScriptOpcodes.CC_SETGRAPHIC) {
var3.spriteId2 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SET2DANGLE) {
}
if (var0 == ScriptOpcodes.CC_SET2DANGLE) {
var3.spriteAngle = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETTILING) {
}
if (var0 == ScriptOpcodes.CC_SETTILING) {
var3.spriteTiling = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETMODEL) {
}
if (var0 == ScriptOpcodes.CC_SETMODEL) {
var3.modelType = 1;
var3.modelId = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETMODELANGLE) {
}
if (var0 == ScriptOpcodes.CC_SETMODELANGLE) {
HealthBarUpdate.Interpreter_intStackSize -= 6;
var3.modelOffsetX = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize];
var3.modelOffsetY = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize + 1];
@@ -138,112 +147,125 @@ public class class83 {
var3.modelZoom = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize + 5];
Strings.method4120(var3);
return 1;
} else {
int var8;
if (var0 == ScriptOpcodes.CC_SETMODELANIM) {
var8 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
if (var8 != var3.sequenceId) {
var3.sequenceId = var8;
var3.modelFrame = 0;
var3.modelFrameCycle = 0;
Strings.method4120(var3);
}
return 1;
} else if (var0 == ScriptOpcodes.CC_SETMODELORTHOG) {
var3.modelOrthog = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETTEXT) {
String var7 = Interpreter.Interpreter_stringStack[--Skills.Interpreter_stringStackSize];
if (!var7.equals(var3.text)) {
var3.text = var7;
Strings.method4120(var3);
}
return 1;
} else if (var0 == ScriptOpcodes.CC_SETTEXTFONT) {
var3.fontId = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETTEXTALIGN) {
HealthBarUpdate.Interpreter_intStackSize -= 3;
var3.textXAlignment = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize];
var3.textYAlignment = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize + 1];
var3.textLineHeight = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize + 2];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETTEXTSHADOW) {
var3.textShadowed = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETOUTLINE) {
var3.outline = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETGRAPHICSHADOW) {
var3.spriteShadow = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETVFLIP) {
var3.spriteFlipV = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETHFLIP) {
var3.spriteFlipH = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETSCROLLSIZE) {
HealthBarUpdate.Interpreter_intStackSize -= 2;
var3.scrollWidth = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize];
var3.scrollHeight = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize + 1];
Strings.method4120(var3);
if (var4 != -1 && var3.type == 0) {
WorldMapSprite.revalidateWidgetScroll(Widget.Widget_interfaceComponents[var4 >> 16], var3, false);
}
return 1;
} else if (var0 == ScriptOpcodes.CC_RESUME_PAUSEBUTTON) {
ScriptFrame.method1086(var3.id, var3.childIndex);
Client.field850 = var3;
Strings.method4120(var3);
return 1;
} else if (var0 == 1122) {
var3.spriteId = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETFILLCOLOUR) {
var3.color2 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == 1124) {
var3.transparencyBot = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
} else if (var0 == ScriptOpcodes.CC_SETFILLMODE) {
var8 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
class323 var6 = (class323)SoundSystem.findEnumerated(PcmPlayer.method2405(), var8);
if (var6 != null) {
var3.fillMode = var6;
Strings.method4120(var3);
}
return 1;
} else {
boolean var5;
if (var0 == ScriptOpcodes.CC_SETLINEDIRECTION) {
var5 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
var3.field2598 = var5;
return 1;
} else if (var0 == ScriptOpcodes.CC_SETMODELTRANSPARENT) {
var5 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
var3.modelTransparency = var5;
return 1;
} else {
return 2;
}
}
}
int var8;
if (var0 == ScriptOpcodes.CC_SETMODELANIM) {
var8 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
if (var8 != var3.sequenceId) {
var3.sequenceId = var8;
var3.modelFrame = 0;
var3.modelFrameCycle = 0;
Strings.method4120(var3);
}
return 1;
}
if (var0 == ScriptOpcodes.CC_SETMODELORTHOG) {
var3.modelOrthog = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETTEXT) {
String var7 = Interpreter.Interpreter_stringStack[--Skills.Interpreter_stringStackSize];
if (!var7.equals(var3.text)) {
var3.text = var7;
Strings.method4120(var3);
}
return 1;
}
if (var0 == ScriptOpcodes.CC_SETTEXTFONT) {
var3.fontId = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETTEXTALIGN) {
HealthBarUpdate.Interpreter_intStackSize -= 3;
var3.textXAlignment = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize];
var3.textYAlignment = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize + 1];
var3.textLineHeight = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize + 2];
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETTEXTSHADOW) {
var3.textShadowed = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETOUTLINE) {
var3.outline = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETGRAPHICSHADOW) {
var3.spriteShadow = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETVFLIP) {
var3.spriteFlipV = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETHFLIP) {
var3.spriteFlipH = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETSCROLLSIZE) {
HealthBarUpdate.Interpreter_intStackSize -= 2;
var3.scrollWidth = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize];
var3.scrollHeight = Interpreter.Interpreter_intStack[HealthBarUpdate.Interpreter_intStackSize + 1];
Strings.method4120(var3);
if (var4 != -1 && var3.type == 0) {
WorldMapSprite.revalidateWidgetScroll(Widget.Widget_interfaceComponents[var4 >> 16], var3, false);
}
return 1;
}
if (var0 == ScriptOpcodes.CC_RESUME_PAUSEBUTTON) {
ScriptFrame.method1086(var3.id, var3.childIndex);
Client.field850 = var3;
Strings.method4120(var3);
return 1;
}
if (var0 == 1122) {
var3.spriteId = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETFILLCOLOUR) {
var3.color2 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
}
if (var0 == 1124) {
var3.transparencyBot = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
Strings.method4120(var3);
return 1;
}
if (var0 == ScriptOpcodes.CC_SETFILLMODE) {
var8 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize];
class323 var6 = (class323)SoundSystem.findEnumerated(PcmPlayer.method2405(), var8);
if (var6 != null) {
var3.fillMode = var6;
Strings.method4120(var3);
}
return 1;
}
boolean var5;
if (var0 == ScriptOpcodes.CC_SETLINEDIRECTION) {
var5 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
var3.field2598 = var5;
return 1;
}
if (var0 == ScriptOpcodes.CC_SETMODELTRANSPARENT) {
var5 = Interpreter.Interpreter_intStack[--HealthBarUpdate.Interpreter_intStackSize] == 1;
var3.modelTransparency = var5;
return 1;
}
return 2;
}
@ObfuscatedName("gp")
@@ -254,9 +276,8 @@ public class class83 {
static final int method1995() {
if (WorldMapLabelSize.clientPreferences.roofsHidden) {
return class42.plane;
} else {
int var0 = ScriptEvent.getTileHeight(PacketBuffer.cameraX, class1.cameraZ, class42.plane);
return var0 - class43.cameraY < 800 && (Tiles.Tiles_renderFlags[class42.plane][PacketBuffer.cameraX >> 7][class1.cameraZ >> 7] & 4) != 0 ? class42.plane : 3;
}
int var0 = ScriptEvent.getTileHeight(PacketBuffer.cameraX, class1.cameraZ, class42.plane);
return var0 - class43.cameraY < 800 && (Tiles.Tiles_renderFlags[class42.plane][PacketBuffer.cameraX >> 7][class1.cameraZ >> 7] & 4) != 0 ? class42.plane : 3;
}
}