rs-client: Cleanup (#1087)

* rs-client: name SpriteBuffer

* rs-client: (re)name spritebuffer methods

* rs-client/deob: Add missed @Export's, make updatemappings fix this next time

* rs-client: run intellij redundant else inspection

* rs-client: invert some script interpreter if's

* deob: checkstyle fixes

* rs-client: SpriteBuffer_loadSprite -> SpriteBuffer_bufferFile
This commit is contained in:
Lucwousin
2019-07-23 19:43:31 +02:00
committed by GitHub
parent 61b4531a0d
commit 596689a4f7
175 changed files with 9825 additions and 9776 deletions

View File

@@ -238,109 +238,107 @@ public class PlayerAppearance {
public Model getModel(SequenceDefinition var1, int var2, SequenceDefinition var3, int var4) {
if (this.npcTransformId != -1) {
return GameShell.getNpcDefinition(this.npcTransformId).getModel(var1, var2, var3, var4);
} else {
long var5 = this.field2539;
int[] var7 = this.equipment;
if (var1 != null && (var1.shield >= 0 || var1.weapon >= 0)) {
var7 = new int[12];
}
long var5 = this.field2539;
int[] var7 = this.equipment;
if (var1 != null && (var1.shield >= 0 || var1.weapon >= 0)) {
var7 = new int[12];
for (int var15 = 0; var15 < 12; ++var15) {
var7[var15] = this.equipment[var15];
for (int var15 = 0; var15 < 12; ++var15) {
var7[var15] = this.equipment[var15];
}
if (var1.shield >= 0) {
var5 += (long)(var1.shield - this.equipment[5] << 40);
var7[5] = var1.shield;
}
if (var1.weapon >= 0) {
var5 += (long)(var1.weapon - this.equipment[3] << 48);
var7[3] = var1.weapon;
}
}
Model var8 = (Model)PlayerAppearance_cachedModels.get(var5);
if (var8 == null) {
boolean var9 = false;
int var11;
for (int var10 = 0; var10 < 12; ++var10) {
var11 = var7[var10];
if (var11 >= 256 && var11 < 512 && !ArchiveDiskAction.getKitDefinition(var11 - 256).ready()) {
var9 = true;
}
if (var1.shield >= 0) {
var5 += (long)(var1.shield - this.equipment[5] << 40);
var7[5] = var1.shield;
}
if (var1.weapon >= 0) {
var5 += (long)(var1.weapon - this.equipment[3] << 48);
var7[3] = var1.weapon;
if (var11 >= 512 && !WorldMapArea.getItemDefinition(var11 - 512).method4646(this.isFemale)) {
var9 = true;
}
}
Model var8 = (Model)PlayerAppearance_cachedModels.get(var5);
if (var8 == null) {
boolean var9 = false;
int var11;
for (int var10 = 0; var10 < 12; ++var10) {
var11 = var7[var10];
if (var11 >= 256 && var11 < 512 && !ArchiveDiskAction.getKitDefinition(var11 - 256).ready()) {
var9 = true;
}
if (var11 >= 512 && !WorldMapArea.getItemDefinition(var11 - 512).method4646(this.isFemale)) {
var9 = true;
}
}
if (var9) {
if (-1L != this.field2537) {
var8 = (Model)PlayerAppearance_cachedModels.get(this.field2537);
}
if (var8 == null) {
return null;
}
if (var9) {
if (-1L != this.field2537) {
var8 = (Model)PlayerAppearance_cachedModels.get(this.field2537);
}
if (var8 == null) {
ModelData[] var16 = new ModelData[12];
var11 = 0;
int var13;
for (int var12 = 0; var12 < 12; ++var12) {
var13 = var7[var12];
ModelData var14;
if (var13 >= 256 && var13 < 512) {
var14 = ArchiveDiskAction.getKitDefinition(var13 - 256).getModelData();
if (var14 != null) {
var16[var11++] = var14;
}
}
if (var13 >= 512) {
var14 = WorldMapArea.getItemDefinition(var13 - 512).method4694(this.isFemale);
if (var14 != null) {
var16[var11++] = var14;
}
}
}
ModelData var17 = new ModelData(var16, var11);
for (var13 = 0; var13 < 5; ++var13) {
if (this.bodyColors[var13] < class247.field3291[var13].length) {
var17.recolor(ModelData0.field1870[var13], class247.field3291[var13][this.bodyColors[var13]]);
}
if (this.bodyColors[var13] < Message.field604[var13].length) {
var17.recolor(WorldMapCacheName.field309[var13], Message.field604[var13][this.bodyColors[var13]]);
}
}
var8 = var17.toModel(64, 850, -30, -50, -30);
PlayerAppearance_cachedModels.put(var8, var5);
this.field2537 = var5;
return null;
}
}
if (var1 == null && var3 == null) {
return var8;
} else {
Model var18;
if (var1 != null && var3 != null) {
var18 = var1.applyTransformations(var8, var2, var3, var4);
} else if (var1 != null) {
var18 = var1.transformActorModel(var8, var2);
} else {
var18 = var3.transformActorModel(var8, var4);
if (var8 == null) {
ModelData[] var16 = new ModelData[12];
var11 = 0;
int var13;
for (int var12 = 0; var12 < 12; ++var12) {
var13 = var7[var12];
ModelData var14;
if (var13 >= 256 && var13 < 512) {
var14 = ArchiveDiskAction.getKitDefinition(var13 - 256).getModelData();
if (var14 != null) {
var16[var11++] = var14;
}
}
if (var13 >= 512) {
var14 = WorldMapArea.getItemDefinition(var13 - 512).method4694(this.isFemale);
if (var14 != null) {
var16[var11++] = var14;
}
}
}
return var18;
ModelData var17 = new ModelData(var16, var11);
for (var13 = 0; var13 < 5; ++var13) {
if (this.bodyColors[var13] < class247.field3291[var13].length) {
var17.recolor(ModelData0.field1870[var13], class247.field3291[var13][this.bodyColors[var13]]);
}
if (this.bodyColors[var13] < Message.field604[var13].length) {
var17.recolor(WorldMapCacheName.field309[var13], Message.field604[var13][this.bodyColors[var13]]);
}
}
var8 = var17.toModel(64, 850, -30, -50, -30);
PlayerAppearance_cachedModels.put(var8, var5);
this.field2537 = var5;
}
}
if (var1 == null && var3 == null) {
return var8;
}
Model var18;
if (var1 != null && var3 != null) {
var18 = var1.applyTransformations(var8, var2, var3, var4);
} else if (var1 != null) {
var18 = var1.transformActorModel(var8, var2);
} else {
var18 = var3.transformActorModel(var8, var4);
}
return var18;
}
@ObfuscatedName("i")
@@ -352,61 +350,59 @@ public class PlayerAppearance {
ModelData getModelData() {
if (this.npcTransformId != -1) {
return GameShell.getNpcDefinition(this.npcTransformId).getModelData();
} else {
boolean var1 = false;
}
boolean var1 = false;
int var3;
for (int var2 = 0; var2 < 12; ++var2) {
var3 = this.equipment[var2];
if (var3 >= 256 && var3 < 512 && !ArchiveDiskAction.getKitDefinition(var3 - 256).method4445()) {
var1 = true;
}
if (var3 >= 512 && !WorldMapArea.getItemDefinition(var3 - 512).method4683(this.isFemale)) {
var1 = true;
}
int var3;
for (int var2 = 0; var2 < 12; ++var2) {
var3 = this.equipment[var2];
if (var3 >= 256 && var3 < 512 && !ArchiveDiskAction.getKitDefinition(var3 - 256).method4445()) {
var1 = true;
}
if (var1) {
return null;
} else {
ModelData[] var7 = new ModelData[12];
var3 = 0;
int var5;
for (int var4 = 0; var4 < 12; ++var4) {
var5 = this.equipment[var4];
ModelData var6;
if (var5 >= 256 && var5 < 512) {
var6 = ArchiveDiskAction.getKitDefinition(var5 - 256).method4441();
if (var6 != null) {
var7[var3++] = var6;
}
}
if (var5 >= 512) {
var6 = WorldMapArea.getItemDefinition(var5 - 512).method4649(this.isFemale);
if (var6 != null) {
var7[var3++] = var6;
}
}
}
ModelData var8 = new ModelData(var7, var3);
for (var5 = 0; var5 < 5; ++var5) {
if (this.bodyColors[var5] < class247.field3291[var5].length) {
var8.recolor(ModelData0.field1870[var5], class247.field3291[var5][this.bodyColors[var5]]);
}
if (this.bodyColors[var5] < Message.field604[var5].length) {
var8.recolor(WorldMapCacheName.field309[var5], Message.field604[var5][this.bodyColors[var5]]);
}
}
return var8;
if (var3 >= 512 && !WorldMapArea.getItemDefinition(var3 - 512).method4683(this.isFemale)) {
var1 = true;
}
}
if (var1) {
return null;
}
ModelData[] var7 = new ModelData[12];
var3 = 0;
int var5;
for (int var4 = 0; var4 < 12; ++var4) {
var5 = this.equipment[var4];
ModelData var6;
if (var5 >= 256 && var5 < 512) {
var6 = ArchiveDiskAction.getKitDefinition(var5 - 256).method4441();
if (var6 != null) {
var7[var3++] = var6;
}
}
if (var5 >= 512) {
var6 = WorldMapArea.getItemDefinition(var5 - 512).method4649(this.isFemale);
if (var6 != null) {
var7[var3++] = var6;
}
}
}
ModelData var8 = new ModelData(var7, var3);
for (var5 = 0; var5 < 5; ++var5) {
if (this.bodyColors[var5] < class247.field3291[var5].length) {
var8.recolor(ModelData0.field1870[var5], class247.field3291[var5][this.bodyColors[var5]]);
}
if (this.bodyColors[var5] < Message.field604[var5].length) {
var8.recolor(WorldMapCacheName.field309[var5], Message.field604[var5][this.bodyColors[var5]]);
}
}
return var8;
}
@ObfuscatedName("c")
@@ -424,14 +420,13 @@ public class PlayerAppearance {
signature = "(Lhp;II)Z",
garbageValue = "-435811450"
)
@Export("SpriteBuffer_loadSpriteFlat")
public static boolean SpriteBuffer_loadSpriteFlat(AbstractArchive var0, int var1) {
@Export("SpriteBuffer_bufferFileFlat")
public static boolean SpriteBuffer_bufferFileFlat(AbstractArchive var0, int var1) {
byte[] var2 = var0.takeFileFlat(var1);
if (var2 == null) {
return false;
} else {
class185.SpriteBuffer_decode(var2);
return true;
}
class185.SpriteBuffer_decode(var2);
return true;
}
}