IsEmpty check moved

This commit is contained in:
Scott Burns
2019-06-01 03:12:23 +02:00
parent d36db6f1a0
commit 4efaea55f7
27 changed files with 30 additions and 104 deletions

View File

@@ -95,10 +95,7 @@ class LapCounterOverlay extends Overlay
tableComponent.addRow("Laps until goal:", Integer.toString(session.getLapsTillGoal())); tableComponent.addRow("Laps until goal:", Integer.toString(session.getLapsTillGoal()));
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -90,10 +90,7 @@ public class BarrowsBrotherSlainOverlay extends Overlay
float rewardPercent = client.getVar(Varbits.BARROWS_REWARD_POTENTIAL) / 10.0f; float rewardPercent = client.getVar(Varbits.BARROWS_REWARD_POTENTIAL) / 10.0f;
tableComponent.addRow("Potential", ColorUtil.prependColorTag(rewardPercent != 0 ? rewardPercent + "%" : "0%", rewardPercent >= 73.0f && rewardPercent <= 88.0f ? Color.GREEN : rewardPercent < 65.6f ? Color.WHITE : Color.YELLOW)); tableComponent.addRow("Potential", ColorUtil.prependColorTag(rewardPercent != 0 ? rewardPercent + "%" : "0%", rewardPercent >= 73.0f && rewardPercent <= 88.0f ? Color.GREEN : rewardPercent < 65.6f ? Color.WHITE : Color.YELLOW));
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -75,10 +75,7 @@ class BlastFurnaceCofferOverlay extends Overlay
TableComponent tableComponent = new TableComponent(); TableComponent tableComponent = new TableComponent();
tableComponent.addRow("Coffer:", StackFormatter.quantityToStackSize(client.getVar(BLAST_FURNACE_COFFER)) + " gp"); tableComponent.addRow("Coffer:", StackFormatter.quantityToStackSize(client.getVar(BLAST_FURNACE_COFFER)) + " gp");
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
} }
return panelComponent.render(graphics); return panelComponent.render(graphics);

View File

@@ -121,10 +121,7 @@ class BoostsOverlay extends Overlay
} }
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -99,10 +99,7 @@ class CookingOverlay extends Overlay
tableComponent.addRow("Cooked:", session.getCookAmount() + (session.getCookAmount() >= 1 ? " (" + xpTrackerService.getActionsHr(Skill.COOKING) + "/hr)" : "")); tableComponent.addRow("Cooked:", session.getCookAmount() + (session.getCookAmount() >= 1 ? " (" + xpTrackerService.getActionsHr(Skill.COOKING) + "/hr)" : ""));
tableComponent.addRow("Burnt:", session.getBurnAmount() + (session.getBurnAmount() >= 1 ? " (" + FORMAT.format(session.getBurntPercentage()) + "%)" : "")); tableComponent.addRow("Burnt:", session.getBurnAmount() + (session.getBurnAmount() >= 1 ? " (" + FORMAT.format(session.getBurntPercentage()) + "%)" : ""));
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -84,10 +84,7 @@ class FermentTimerOverlay extends Overlay
tableComponent.setColumnAlignments(TableAlignment.LEFT, TableAlignment.RIGHT); tableComponent.setColumnAlignments(TableAlignment.LEFT, TableAlignment.RIGHT);
tableComponent.addRow("Ferments in:", String.valueOf(INITIAL_TIME - Duration.between(session.getLastWineMakingAction(), Instant.now()).getSeconds())); tableComponent.addRow("Ferments in:", String.valueOf(INITIAL_TIME - Duration.between(session.getLastWineMakingAction(), Instant.now()).getSeconds()));
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
} }
else else
{ {

View File

@@ -74,10 +74,7 @@ public class VanguardsOverlay extends Overlay
tableComponent.addRow(ColorUtil.prependColorTag("Mage", Color.BLUE), Integer.toString(plugin.getMageVangHP())); tableComponent.addRow(ColorUtil.prependColorTag("Mage", Color.BLUE), Integer.toString(plugin.getMageVangHP()));
tableComponent.addRow(ColorUtil.prependColorTag("Melee", Color.RED), Integer.toString(plugin.getMeleeVangHP())); tableComponent.addRow(ColorUtil.prependColorTag("Melee", Color.RED), Integer.toString(plugin.getMeleeVangHP()));
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -69,10 +69,7 @@ public class CameraOverlay extends Overlay
tableComponent.addRow("Yaw", "" + client.getCameraYaw()); tableComponent.addRow("Yaw", "" + client.getCameraYaw());
tableComponent.addRow("Scale", "" + client.getScale()); tableComponent.addRow("Scale", "" + client.getScale());
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -98,10 +98,7 @@ public class LocationOverlay extends Overlay
tableComponent.addRow((i == 0) ? "Map regions" : " ", ColorUtil.prependColorTag(String.valueOf(region), (region == regionID) ? Color.GREEN : Color.WHITE)); tableComponent.addRow((i == 0) ? "Map regions" : " ", ColorUtil.prependColorTag(String.valueOf(region), (region == regionID) ? Color.GREEN : Color.WHITE));
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -104,10 +104,7 @@ class WaveOverlay extends Overlay
tableComponent.addRow(line); tableComponent.addRow(line);
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
} }
private static Collection<String> buildWaveLines(final Map<WaveMonster, Integer> wave) private static Collection<String> buildWaveLines(final Map<WaveMonster, Integer> wave)

View File

@@ -102,10 +102,7 @@ class FishingOverlay extends Overlay
tableComponent.addRow("Fish/hr:", Integer.toString(xpTrackerService.getActionsHr(Skill.FISHING))); tableComponent.addRow("Fish/hr:", Integer.toString(xpTrackerService.getActionsHr(Skill.FISHING)));
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
} }
return panelComponent.render(graphics); return panelComponent.render(graphics);

View File

@@ -113,10 +113,7 @@ class MiningOverlay extends Overlay
tableComponent.addRow("Pay-dirt mined:", Integer.toString(session.getTotalMined())); tableComponent.addRow("Pay-dirt mined:", Integer.toString(session.getTotalMined()));
tableComponent.addRow("Pay-dirt/hr:", session.getRecentMined() > 2 ? Integer.toString(session.getPerHour()) : ""); tableComponent.addRow("Pay-dirt/hr:", session.getRecentMined() > 2 ? Integer.toString(session.getPerHour()) : "");
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -106,10 +106,7 @@ public class MotherlodeGemOverlay extends Overlay
tableComponent.addRow("Sapphires:", Integer.toString(sapphiresFound)); tableComponent.addRow("Sapphires:", Integer.toString(sapphiresFound));
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -110,10 +110,7 @@ public class MotherlodeOreOverlay extends Overlay
tableComponent.addRow("Runite:", Integer.toString(runiteFound)); tableComponent.addRow("Runite:", Integer.toString(runiteFound));
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -116,10 +116,7 @@ class MotherlodeOverlay extends Overlay
tableComponent.addRow("Pay-dirt mined:", Integer.toString(session.getTotalMined())); tableComponent.addRow("Pay-dirt mined:", Integer.toString(session.getTotalMined()));
tableComponent.addRow("Pay-dirt/hr:", session.getRecentMined() > 2 ? Integer.toString(session.getPerHour()) : ""); tableComponent.addRow("Pay-dirt/hr:", session.getRecentMined() > 2 ? Integer.toString(session.getPerHour()) : "");
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -116,10 +116,7 @@ class MotherlodeSackOverlay extends Overlay
} }
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -171,10 +171,7 @@ class PlayerComparisonOverlay extends Overlay
ColorUtil.prependColorTag(Integer.toString(opponentSkillLevel), comparisonStatColor(opponentSkillLevel, playerSkillLevel))); ColorUtil.prependColorTag(Integer.toString(opponentSkillLevel), comparisonStatColor(opponentSkillLevel, playerSkillLevel)));
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
} }
private static Color comparisonStatColor(int a, int b) private static Color comparisonStatColor(int a, int b)

View File

@@ -361,10 +361,7 @@ public class RaidsOverlay extends Overlay
roomCount++; roomCount++;
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
Dimension panelDims = panelComponent.render(graphics); Dimension panelDims = panelComponent.render(graphics);
width = (int) panelDims.getWidth(); width = (int) panelDims.getWidth();

View File

@@ -108,10 +108,7 @@ public class RaidsPointsOverlay extends Overlay
.build()); .build());
}*/ }*/
if (!tableComponent.isEmpty()) panel.getChildren().add(tableComponent);
{
panel.getChildren().add(tableComponent);
}
return panel.render(graphics); return panel.render(graphics);
} }

View File

@@ -111,10 +111,7 @@ class SmeltingOverlay extends Overlay
tableComponent.addRow("Actions/hr:", Integer.toString(xpTrackerService.getActionsHr(Skill.SMITHING))); tableComponent.addRow("Actions/hr:", Integer.toString(xpTrackerService.getActionsHr(Skill.SMITHING)));
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
} }
return panelComponent.render(graphics); return panelComponent.render(graphics);

View File

@@ -128,10 +128,7 @@ class NyloOverlay extends Overlay
} }
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
/** /**

View File

@@ -62,10 +62,7 @@ public class XarpusCounter extends Overlay
TableComponent tableComponent = new TableComponent(); TableComponent tableComponent = new TableComponent();
tableComponent.addRow("Exhumes", String.valueOf(xarpusHandler.getExhumesCount())); tableComponent.addRow("Exhumes", String.valueOf(xarpusHandler.getExhumesCount()));
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -102,10 +102,7 @@ public class ThievingOverlay extends Overlay
tableComponent.addRow("Succeeded:", session.getSuccessful() + (session.getSuccessful() >= 1 ? " (" + xpTrackerService.getActionsHr(Skill.THIEVING) + "/hr)" : "")); tableComponent.addRow("Succeeded:", session.getSuccessful() + (session.getSuccessful() >= 1 ? " (" + xpTrackerService.getActionsHr(Skill.THIEVING) + "/hr)" : ""));
tableComponent.addRow("Failed:", session.getFailed() + (session.getFailed() >= 1 ? " (" + FORMAT.format(session.getSuccessRate()) + "%)" : "")); tableComponent.addRow("Failed:", session.getFailed() + (session.getFailed() >= 1 ? " (" + FORMAT.format(session.getSuccessRate()) + "%)" : ""));
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -95,10 +95,7 @@ class WintertodtOverlay extends Overlay
tableComponent.addRow(ColorUtil.prependColorTag("Kindling:", Color.WHITE), ColorUtil.prependColorTag(kindlingScore + " pts (" + kindlingXp + " xp)", plugin.getNumKindling() > 0 ? Color.GREEN : Color.RED)); tableComponent.addRow(ColorUtil.prependColorTag("Kindling:", Color.WHITE), ColorUtil.prependColorTag(kindlingScore + " pts (" + kindlingXp + " xp)", plugin.getNumKindling() > 0 ? Color.GREEN : Color.RED));
tableComponent.addRow(ColorUtil.prependColorTag("Total:", Color.WHITE), ColorUtil.prependColorTag((rootsScore + kindlingScore) + " pts (" + (rootsXp + kindlingXp) + " xp)", (rootsScore + kindlingScore > 0) ? Color.GREEN : Color.RED)); tableComponent.addRow(ColorUtil.prependColorTag("Total:", Color.WHITE), ColorUtil.prependColorTag((rootsScore + kindlingScore) + " pts (" + (rootsXp + kindlingXp) + " xp)", (rootsScore + kindlingScore > 0) ? Color.GREEN : Color.RED));
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -107,10 +107,7 @@ class WoodcuttingOverlay extends Overlay
} }
} }
if (!tableComponent.isEmpty()) panelComponent.getChildren().add(tableComponent);
{
panelComponent.getChildren().add(tableComponent);
}
return panelComponent.render(graphics); return panelComponent.render(graphics);
} }

View File

@@ -280,10 +280,7 @@ public class XpGlobesOverlay extends Overlay
} }
} }
if (!tableComponent.isEmpty()) xpTooltip.getChildren().add(tableComponent);
{
xpTooltip.getChildren().add(tableComponent);
}
xpTooltip.render(graphics); xpTooltip.render(graphics);
} }

View File

@@ -34,6 +34,7 @@ import java.util.List;
import javax.annotation.Nullable; import javax.annotation.Nullable;
import lombok.Getter; import lombok.Getter;
import lombok.Setter; import lombok.Setter;
import net.runelite.client.ui.overlay.components.table.TableComponent;
public class PanelComponent implements LayoutableRenderableEntity public class PanelComponent implements LayoutableRenderableEntity
{ {
@@ -74,6 +75,8 @@ public class PanelComponent implements LayoutableRenderableEntity
@Override @Override
public Dimension render(Graphics2D graphics) public Dimension render(Graphics2D graphics)
{ {
children.removeIf(child -> child instanceof TableComponent && ((TableComponent) child).isEmpty());
if (children.isEmpty()) if (children.isEmpty())
{ {
return null; return null;
@@ -114,6 +117,7 @@ public class PanelComponent implements LayoutableRenderableEntity
for (int i = 0; i < children.size(); i++) for (int i = 0; i < children.size(); i++)
{ {
final LayoutableRenderableEntity child = children.get(i); final LayoutableRenderableEntity child = children.get(i);
child.setPreferredLocation(new Point(x, y)); child.setPreferredLocation(new Point(x, y));
child.setPreferredSize(childPreferredSize); child.setPreferredSize(childPreferredSize);
final Dimension childDimension = child.render(graphics); final Dimension childDimension = child.render(graphics);