ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Log config property changes only if they really change

Browse Source 
This prevents spam from previous property loading addition

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
This commit is contained in:
Tomas Slusny
2019-02-22 00:39:17 +01:00
parent 67ac960b66
commit 4e1e132985
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
runelite-client/src/main/java/net/runelite/client/config/ConfigManager.java
View File

@@ -372,8 +372,6 @@ public class ConfigManager
public void setConfiguration(String groupName, String key, String value) public void setConfiguration(String groupName, String key, String value)
{ {
log.debug("Setting configuration value for {}.{} to {}", groupName, key, value);
String oldValue = (String) properties.setProperty(groupName + "." + key, value); String oldValue = (String) properties.setProperty(groupName + "." + key, value);
if (Objects.equals(oldValue, value)) if (Objects.equals(oldValue, value))
@@ -381,6 +379,8 @@ public class ConfigManager
return; return;
} }
log.debug("Setting configuration value for {}.{} to {}", groupName, key, value);
synchronized (pendingChanges) synchronized (pendingChanges)
{ {
pendingChanges.put(groupName + "." + key, value); pendingChanges.put(groupName + "." + key, value);
@@ -415,8 +415,6 @@ public class ConfigManager
public void unsetConfiguration(String groupName, String key) public void unsetConfiguration(String groupName, String key)
{ {
log.debug("Unsetting configuration value for {}.{}", groupName, key);
String oldValue = (String) properties.remove(groupName + "." + key); String oldValue = (String) properties.remove(groupName + "." + key);
if (oldValue == null) if (oldValue == null)
@@ -424,6 +422,8 @@ public class ConfigManager
return; return;
} }
log.debug("Unsetting configuration value for {}.{}", groupName, key);
synchronized (pendingChanges) synchronized (pendingChanges)
{ {
pendingChanges.put(groupName + "." + key, null); pendingChanges.put(groupName + "." + key, null);