ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

slayer plugin: don't lowercase task names

Browse Source
This commit is contained in:
Adam
2018-07-07 20:31:16 -04:00
parent 4a26a39068
commit 48708fd3d3
3 changed files with 104 additions and 117 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runelite-client/src/main/java/net/runelite/client/plugins/slayer/SlayerPlugin.java
View File

@@ -476,7 +476,7 @@ public class SlayerPlugin extends Plugin
private void setTask(String name, int amt) private void setTask(String name, int amt)
{ {
taskName = name.toLowerCase(); taskName = name;
amount = amt; amount = amt;
save(); save();
removeCounter(); removeCounter();

215
runelite-client/src/main/java/net/runelite/client/plugins/slayer/Task.java
View File

@@ -28,107 +28,109 @@ package net.runelite.client.plugins.slayer;
import com.google.common.base.Preconditions; import com.google.common.base.Preconditions;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
import lombok.Getter;
import net.runelite.api.ItemID; import net.runelite.api.ItemID;
@Getter
enum Task enum Task
{ {
//<editor-fold desc="Enums"> //<editor-fold desc="Enums">
ABERRANT_SPECTRES("aberrant spectres", ItemID.ABERRANT_SPECTRE, "spectre"), ABERRANT_SPECTRES("Aberrant spectres", ItemID.ABERRANT_SPECTRE, "Spectre"),
ABYSSAL_DEMONS("abyssal demons", ItemID.ABYSSAL_DEMON), ABYSSAL_DEMONS("Abyssal demons", ItemID.ABYSSAL_DEMON),
ADAMANT_DRAGONS("adamant dragons", ItemID.ADAMANTITE_BAR), ADAMANT_DRAGONS("Adamant dragons", ItemID.ADAMANTITE_BAR),
ANKOU("ankou", ItemID.ANKOU_MASK), ANKOU("Ankou", ItemID.ANKOU_MASK),
AVIANSIES("aviansies", ItemID.ENSOULED_AVIANSIE_HEAD), AVIANSIES("Aviansies", ItemID.ENSOULED_AVIANSIE_HEAD),
BANSHEES("banshees", ItemID.BANSHEE), BANSHEES("Banshees", ItemID.BANSHEE),
BASILISKS("basilisks", ItemID.BASILISK), BASILISKS("Basilisks", ItemID.BASILISK),
BATS("bats", ItemID.GIRAL_BAT_2), BATS("Bats", ItemID.GIRAL_BAT_2),
BEARS("bears", ItemID.ENSOULED_BEAR_HEAD), BEARS("Bears", ItemID.ENSOULED_BEAR_HEAD),
BIRDS("birds", ItemID.FEATHER, "chicken", "rooster", "terrorbird"), BIRDS("Birds", ItemID.FEATHER, "Chicken", "Rooster", "Terrorbird"),
BLACK_DEMONS("black demons", ItemID.BLACK_DEMON_MASK), BLACK_DEMONS("Black demons", ItemID.BLACK_DEMON_MASK),
BLACK_DRAGONS("black dragons", ItemID.BLACK_DRAGON_MASK), BLACK_DRAGONS("Black dragons", ItemID.BLACK_DRAGON_MASK),
BLOODVELD("bloodveld", ItemID.BLOODVELD), BLOODVELD("Bloodveld", ItemID.BLOODVELD),
BLUE_DRAGONS("blue dragons", ItemID.BLUE_DRAGON_MASK), BLUE_DRAGONS("Blue dragons", ItemID.BLUE_DRAGON_MASK),
BRINE_RATS("brine rats", ItemID.BRINE_RAT), BRINE_RATS("Brine rats", ItemID.BRINE_RAT),
BRONZE_DRAGONS("bronze dragons", ItemID.BRONZE_DRAGON_MASK), BRONZE_DRAGONS("Bronze dragons", ItemID.BRONZE_DRAGON_MASK),
CATABLEPON("catablepon", ItemID.LEFT_SKULL_HALF), CATABLEPON("Catablepon", ItemID.LEFT_SKULL_HALF),
CAVE_BUGS("cave bugs", ItemID.SWAMP_CAVE_BUG), CAVE_BUGS("Cave bugs", ItemID.SWAMP_CAVE_BUG),
CAVE_CRAWLERS("cave crawlers", ItemID.CAVE_CRAWLER, "chasm crawler"), CAVE_CRAWLERS("Cave crawlers", ItemID.CAVE_CRAWLER, "Chasm crawler"),
CAVE_HORRORS("cave horrors", ItemID.CAVE_HORROR, "cave abomination"), CAVE_HORRORS("Cave horrors", ItemID.CAVE_HORROR, "Cave abomination"),
CAVE_KRAKEN("cave kraken", ItemID.CAVE_KRAKEN), CAVE_KRAKEN("Cave kraken", ItemID.CAVE_KRAKEN),
CAVE_SLIMES("cave slimes", ItemID.SWAMP_CAVE_SLIME), CAVE_SLIMES("Cave slimes", ItemID.SWAMP_CAVE_SLIME),
COCKATRICE("cockatrice", ItemID.COCKATRICE, "cockathrice"), COCKATRICE("Cockatrice", ItemID.COCKATRICE, "Cockathrice"),
COWS("cows", ItemID.COW_MASK), COWS("Cows", ItemID.COW_MASK),
CRAWLING_HANDS("crawling hands", ItemID.CRAWLING_HAND, "crushing hand"), CRAWLING_HANDS("Crawling hands", ItemID.CRAWLING_HAND, "Crushing hand"),
CROCODILES("crocodiles", ItemID.SWAMP_LIZARD), CROCODILES("Crocodiles", ItemID.SWAMP_LIZARD),
DAGANNOTH("dagannoth", ItemID.DAGANNOTH), DAGANNOTH("Dagannoth", ItemID.DAGANNOTH),
DARK_BEASTS("dark beasts", ItemID.DARK_BEAST, "night beast"), DARK_BEASTS("Dark beasts", ItemID.DARK_BEAST, "Night beast"),
DESERT_LIZARDS("desert lizards", ItemID.DESERT_LIZARD), DESERT_LIZARDS("Desert lizards", ItemID.DESERT_LIZARD),
DOGS("dogs", ItemID.GUARD_DOG, "jackal"), DOGS("Dogs", ItemID.GUARD_DOG, "Jackal"),
DUST_DEVILS("dust devils", ItemID.DUST_DEVIL, "choke devil"), DUST_DEVILS("Dust devils", ItemID.DUST_DEVIL, "Choke devil"),
DWARVES("dwarves", ItemID.DWARVEN_HELMET, "dwarf"), DWARVES("Dwarves", ItemID.DWARVEN_HELMET, "Dwarf"),
EARTH_WARRIORS("earth warriors", ItemID.BRONZE_FULL_HELM_T), EARTH_WARRIORS("Earth warriors", ItemID.BRONZE_FULL_HELM_T),
ELVES("elves", ItemID.ELF, "elf"), ELVES("Elves", ItemID.ELF, "Elf"),
FEVER_SPIDERS("fever spiders", ItemID.FEVER_SPIDER), FEVER_SPIDERS("Fever spiders", ItemID.FEVER_SPIDER),
FIRE_GIANTS("fire giants", ItemID.FIRE_BATTLESTAFF), FIRE_GIANTS("Fire giants", ItemID.FIRE_BATTLESTAFF),
FLESH_CRAWLERS("flesh crawlers", ItemID.ENSOULED_SCORPION_HEAD), FLESH_CRAWLERS("Flesh crawlers", ItemID.ENSOULED_SCORPION_HEAD),
FOSSIL_ISLAND_WYVERNS("fossil island wyverns", ItemID.FOSSIL_ISLAND_WYVERN, "ancient wyvern", "long-tailed wyvern", "spitting wyvern", "taloned wyvern"), FOSSIL_ISLAND_WYVERNS("Fossil island wyverns", ItemID.FOSSIL_ISLAND_WYVERN, "Ancient wyvern", "Long-tailed wyvern", "Spitting wyvern", "Taloned wyvern"),
GARGOYLES("gargoyles", ItemID.GARGOYLE), GARGOYLES("Gargoyles", ItemID.GARGOYLE),
GHOSTS("ghosts", ItemID.GHOSTSPEAK_AMULET, "tortured soul"), GHOSTS("Ghosts", ItemID.GHOSTSPEAK_AMULET, "Tortured soul"),
GHOULS("ghouls", ItemID.ZOMBIE_HEAD), GHOULS("Ghouls", ItemID.ZOMBIE_HEAD),
GOBLINS("goblins", ItemID.ENSOULED_GOBLIN_HEAD), GOBLINS("Goblins", ItemID.ENSOULED_GOBLIN_HEAD),
GREATER_DEMONS("greater demons", ItemID.GREATER_DEMON_MASK), GREATER_DEMONS("Greater demons", ItemID.GREATER_DEMON_MASK),
GREEN_DRAGONS("green dragons", ItemID.GREEN_DRAGON_MASK), GREEN_DRAGONS("Green dragons", ItemID.GREEN_DRAGON_MASK),
HARPIE_BUG_SWARMS("harpie bug swarms", ItemID.SWARM), HARPIE_BUG_SWARMS("Harpie bug swarms", ItemID.SWARM),
HELLHOUNDS("hellhounds", ItemID.HELLHOUND), HELLHOUNDS("Hellhounds", ItemID.HELLHOUND),
HILL_GIANTS("hill giants", ItemID.ENSOULED_GIANT_HEAD), HILL_GIANTS("Hill giants", ItemID.ENSOULED_GIANT_HEAD),
HOBGOBLINS("hobgoblins", ItemID.HOBGOBLIN_GUARD), HOBGOBLINS("Hobgoblins", ItemID.HOBGOBLIN_GUARD),
ICE_GIANTS("ice giants", ItemID.ICE_DIAMOND), ICE_GIANTS("Ice giants", ItemID.ICE_DIAMOND),
ICE_WARRIORS("ice warriors", ItemID.MITHRIL_FULL_HELM_T), ICE_WARRIORS("Ice warriors", ItemID.MITHRIL_FULL_HELM_T),
ICEFIENDS("icefiends", ItemID.ICE_DIAMOND), ICEFIENDS("Icefiends", ItemID.ICE_DIAMOND),
INFERNAL_MAGES("infernal mages", ItemID.INFERNAL_MAGE, "malevolent mage"), INFERNAL_MAGES("Infernal mages", ItemID.INFERNAL_MAGE, "Malevolent mage"),
IRON_DRAGONS("iron dragons", ItemID.IRON_DRAGON_MASK), IRON_DRAGONS("Iron dragons", ItemID.IRON_DRAGON_MASK),
JELLIES("jellies", ItemID.JELLY, "jelly"), JELLIES("Jellies", ItemID.JELLY, "Jelly"),
JUNGLE_HORROR("jungle horrors", ItemID.ENSOULED_HORROR_HEAD), JUNGLE_HORROR("Jungle horrors", ItemID.ENSOULED_HORROR_HEAD),
KALPHITE("kalphite", ItemID.KALPHITE_SOLDIER), KALPHITE("Kalphite", ItemID.KALPHITE_SOLDIER),
KILLERWATTS("killerwatts", ItemID.KILLERWATT), KILLERWATTS("Killerwatts", ItemID.KILLERWATT),
KURASK("kurask", ItemID.KURASK), KURASK("Kurask", ItemID.KURASK),
LESSER_DEMONS("lesser demons", ItemID.LESSER_DEMON_MASK), LESSER_DEMONS("Lesser demons", ItemID.LESSER_DEMON_MASK),
LIZARDMEN("lizardmen", ItemID.LIZARDMAN_FANG, "lizardman"), LIZARDMEN("Lizardmen", ItemID.LIZARDMAN_FANG, "Lizardman"),
MINIONS_OF_SCABARAS("minions of scabaras", ItemID.GOLDEN_SCARAB, "scarab swarm", "locust rider", "scarab mage"), MINIONS_OF_SCABARAS("Minions of scabaras", ItemID.GOLDEN_SCARAB, "Scarab swarm", "Locust rider", "Scarab mage"),
MINOTAURS("minotaurs", ItemID.ENSOULED_MINOTAUR_HEAD), MINOTAURS("Minotaurs", ItemID.ENSOULED_MINOTAUR_HEAD),
MITHRIL_DRAGONS("mithril dragons", ItemID.MITHRIL_DRAGON_MASK), MITHRIL_DRAGONS("Mithril dragons", ItemID.MITHRIL_DRAGON_MASK),
MOGRES("mogres", ItemID.MOGRE), MOGRES("Mogres", ItemID.MOGRE),
MOLANISKS("molanisks", ItemID.MOLANISK), MOLANISKS("Molanisks", ItemID.MOLANISK),
MONKEYS("monkeys", ItemID.ENSOULED_MONKEY_HEAD), MONKEYS("Monkeys", ItemID.ENSOULED_MONKEY_HEAD),
MOSS_GIANTS("moss giants", ItemID.HILL_GIANT_CLUB), MOSS_GIANTS("Moss giants", ItemID.HILL_GIANT_CLUB),
MUTATED_ZYGOMITES("mutated zygomites", ItemID.MUTATED_ZYGOMITE), MUTATED_ZYGOMITES("Mutated zygomites", ItemID.MUTATED_ZYGOMITE),
NECHRYAEL("nechryael", ItemID.NECHRYAEL, "nechryarch"), NECHRYAEL("Nechryael", ItemID.NECHRYAEL, "Nechryarch"),
OGRES("ogres", ItemID.ENSOULED_OGRE_HEAD), OGRES("Ogres", ItemID.ENSOULED_OGRE_HEAD),
OTHERWORLDLY_BEING("otherworldly being", ItemID.GHOSTLY_HOOD), OTHERWORLDLY_BEING("Otherworldly being", ItemID.GHOSTLY_HOOD),
PYREFIENDS("pyrefiends", ItemID.PYREFIEND, "flaming pyrelord"), PYREFIENDS("Pyrefiends", ItemID.PYREFIEND, "Flaming pyrelord"),
RATS("rats", ItemID.RATS_TAIL), RATS("Rats", ItemID.RATS_TAIL),
RED_DRAGONS("red dragons", ItemID.BABY_RED_DRAGON), RED_DRAGONS("Red dragons", ItemID.BABY_RED_DRAGON),
ROCKSLUGS("rockslugs", ItemID.ROCKSLUG), ROCKSLUGS("Rockslugs", ItemID.ROCKSLUG),
RUNE_DRAGONS("rune dragons", ItemID.RUNITE_BAR), RUNE_DRAGONS("Rune dragons", ItemID.RUNITE_BAR),
SCORPIONS("scorpions", ItemID.ENSOULED_SCORPION_HEAD), SCORPIONS("Scorpions", ItemID.ENSOULED_SCORPION_HEAD),
SEA_SNAKES("sea snakes", ItemID.SNAKE_CORPSE), SEA_SNAKES("Sea snakes", ItemID.SNAKE_CORPSE),
SHADES("shades", ItemID.SHADE_ROBE_TOP), SHADES("Shades", ItemID.SHADE_ROBE_TOP),
SHADOW_WARRIORS("shadow warriors", ItemID.BLACK_FULL_HELM), SHADOW_WARRIORS("Shadow warriors", ItemID.BLACK_FULL_HELM),
SKELETAL_WYVERNS("skeletal wyverns", ItemID.SKELETAL_WYVERN), SKELETAL_WYVERNS("Skeletal wyverns", ItemID.SKELETAL_WYVERN),
SKELETONS("skeletons", ItemID.SKELETON_GUARD), SKELETONS("Skeletons", ItemID.SKELETON_GUARD),
SMOKE_DEVILS("smoke devils", ItemID.SMOKE_DEVIL), SMOKE_DEVILS("Smoke devils", ItemID.SMOKE_DEVIL),
SPIDERS("spiders", ItemID.HUGE_SPIDER), SPIDERS("Spiders", ItemID.HUGE_SPIDER),
STEEL_DRAGONS("steel dragons", ItemID.STEEL_DRAGON), STEEL_DRAGONS("Steel dragons", ItemID.STEEL_DRAGON),
SUQAHS("suqahs", ItemID.SUQAH_TOOTH), SUQAHS("Suqahs", ItemID.SUQAH_TOOTH),
TERROR_DOGS("terror dogs", ItemID.TERROR_DOG), TERROR_DOGS("Terror dogs", ItemID.TERROR_DOG),
TROLLS("trolls", ItemID.TROLL_GUARD), TROLLS("Trolls", ItemID.TROLL_GUARD),
TUROTH("turoth", ItemID.TUROTH), TUROTH("Turoth", ItemID.TUROTH),
TZHAAR("tzhaar", ItemID.ENSOULED_TZHAAR_HEAD), TZHAAR("Tzhaar", ItemID.ENSOULED_TZHAAR_HEAD),
VAMPIRES("vampires", ItemID.STAKE), VAMPIRES("Vampires", ItemID.STAKE),
WALL_BEASTS("wall beasts", ItemID.SWAMP_WALLBEAST), WALL_BEASTS("Wall beasts", ItemID.SWAMP_WALLBEAST),
WATERFIENDS("waterfiends", ItemID.WATER_ORB), WATERFIENDS("Waterfiends", ItemID.WATER_ORB),
WEREWOLVES("werewolves", ItemID.WOLFBANE, "werewolf"), WEREWOLVES("Werewolves", ItemID.WOLFBANE, "Werewolf"),
WOLVES("wolves", ItemID.GREY_WOLF_FUR, "wolf"), WOLVES("Wolves", ItemID.GREY_WOLF_FUR, "Wolf"),
ZOMBIES("zombies", ItemID.ZOMBIE_HEAD, "undead"); ZOMBIES("Zombies", ItemID.ZOMBIE_HEAD, "Undead");
//</editor-fold> //</editor-fold>
private static final Map<String, Task> tasks = new HashMap<>(); private static final Map<String, Task> tasks = new HashMap<>();
@@ -141,7 +143,7 @@ enum Task
{ {
for (Task task : values()) for (Task task : values())
{ {
tasks.put(task.getName(), task); tasks.put(task.getName().toLowerCase(), task);
} }
} }
@@ -153,23 +155,8 @@ enum Task
this.targetNames = targetNames; this.targetNames = targetNames;
} }
public static Task getTask(String taskName) static Task getTask(String taskName)
{ {
return tasks.get(taskName); return tasks.get(taskName.toLowerCase());
}
public String getName()
{
return this.name;
}
public int getItemSpriteId()
{
return itemSpriteId;
}
public String[] getTargetNames()
{
return this.targetNames;
} }
} }

4
runelite-client/src/test/java/net/runelite/client/plugins/slayer/SlayerPluginTest.java
View File

@@ -130,7 +130,7 @@ public class SlayerPluginTest
when(client.getWidget(WidgetInfo.DIALOG_NPC_TEXT)).thenReturn(npcDialog); when(client.getWidget(WidgetInfo.DIALOG_NPC_TEXT)).thenReturn(npcDialog);
slayerPlugin.onGameTick(new GameTick()); slayerPlugin.onGameTick(new GameTick());
assertEquals("suqahs", slayerPlugin.getTaskName()); assertEquals("Suqahs", slayerPlugin.getTaskName());
assertEquals(231, slayerPlugin.getAmount()); assertEquals(231, slayerPlugin.getAmount());
} }
@@ -142,7 +142,7 @@ public class SlayerPluginTest
when(client.getWidget(WidgetInfo.DIALOG_NPC_TEXT)).thenReturn(npcDialog); when(client.getWidget(WidgetInfo.DIALOG_NPC_TEXT)).thenReturn(npcDialog);
slayerPlugin.onGameTick(new GameTick()); slayerPlugin.onGameTick(new GameTick());
assertEquals("suqahs", slayerPlugin.getTaskName()); assertEquals("Suqahs", slayerPlugin.getTaskName());
assertEquals(211, slayerPlugin.getAmount()); assertEquals(211, slayerPlugin.getAmount());
} }