From 42ad93c33cd6ddbdd716c83f49e65fce125b4bff Mon Sep 17 00:00:00 2001 From: Adam Date: Wed, 7 Nov 2018 18:05:34 -0500 Subject: [PATCH] entity hider: check for players with no names Not sure why this happens but we have stacktraces of isFriend crashing due to a player not having a name (yet?). It looks like the names are sent separately from the player spawn in the protocol. --- .../src/main/java/net/runelite/mixins/EntityHiderMixin.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/runelite-mixins/src/main/java/net/runelite/mixins/EntityHiderMixin.java b/runelite-mixins/src/main/java/net/runelite/mixins/EntityHiderMixin.java index 7c89d3ee0d..d055fceed5 100644 --- a/runelite-mixins/src/main/java/net/runelite/mixins/EntityHiderMixin.java +++ b/runelite-mixins/src/main/java/net/runelite/mixins/EntityHiderMixin.java @@ -139,6 +139,12 @@ public abstract class EntityHiderMixin implements RSScene } } + if (player.getName() == null) + { + // player.isFriend() and player.isClanMember() npe when the player has a null name + return false; + } + return (!hideFriends && player.isFriend()) || (!isLocalPlayer && !hideClanMates && player.isClanMember()); } }