ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

farmingtracker: Correct several patch timings

Browse Source 
There were several places where the autogenerated patch implementations would double count a stage, and miss another. PatchImplementationTest now checks for missed stages, excluding the final stage because that is often missed on plants which do not have a "Check-health" stage. There were also a couple produces with incorrect tick counts.
This commit is contained in:
Max Weber
2018-07-01 14:03:35 -06:00
parent abce07bcc7
commit 4117472037
3 changed files with 33 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
runelite-client/src/test/java/net/runelite/client/plugins/farmingtracker/PatchImplementationTest.java
View File

@@ -24,6 +24,8 @@
*/
package net.runelite.client.plugins.farmingtracker;
import java.util.HashMap;
import java.util.Map;
import org.junit.Assert;
import org.junit.Test;
@@ -34,6 +36,7 @@ public class PatchImplementationTest
{
for (PatchImplementation impl : PatchImplementation.values())
{
Map<Produce, boolean[]> harvestStages = new HashMap<>();
for (int i = 0; i < 256; i++)
{
PatchState s = impl.forVarbitValue(i);
@@ -53,6 +56,20 @@ public class PatchImplementationTest
{
Assert.assertTrue(pfx + ": dead seed", s.getStage() > 0);
}
if (s.getCropState() == CropState.GROWING && s.getProduce() != Produce.WEEDS)
{
harvestStages.computeIfAbsent(s.getProduce(), k -> new boolean[s.getProduce().getStages()])[s.getStage()] = true;
}
}
}
for (Map.Entry<Produce, boolean[]> produce : harvestStages.entrySet())
{
boolean[] states = produce.getValue();
// Alot of time the final stage is not hit, because some plants do not have a "Check-health" stage
for (int i = 0; i < states.length - 1; i++)
{
Assert.assertTrue(produce.getKey().getName() + " stage " + i + " never found by varbit", states[i]);
}
}
}