ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Don't show experience progress for unranked skills

Browse Source 
`Experience.getLevelForXp` crashes on values < 0 (unranked is -1).
This commit is contained in:
Alex Kolpa
2018-05-21 23:31:36 +02:00
parent 0b63291bbf
commit 3be81ae012
1 changed files with 18 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
runelite-client/src/main/java/net/runelite/client/plugins/hiscore/HiscorePanel.java
View File

@@ -639,7 +639,10 @@ public class HiscorePanel extends PluginPanel
*/ */
if (SKILLS.contains(skill)) if (SKILLS.contains(skill))
{ {
int currentLevel = Experience.getLevelForXp((int) result.getSkill(skill).getExperience()); long experience = result.getSkill(skill).getExperience();
if (experience >= 0)
{
int currentLevel = Experience.getLevelForXp((int) experience);
int currentXp = (int) result.getSkill(skill).getExperience(); int currentXp = (int) result.getSkill(skill).getExperience();
int xpForCurrentLevel = Experience.getXpForLevel(currentLevel); int xpForCurrentLevel = Experience.getXpForLevel(currentLevel);
int xpForNextLevel = currentLevel + 1 <= Experience.MAX_VIRT_LEVEL ? Experience.getXpForLevel(currentLevel + 1) : -1; int xpForNextLevel = currentLevel + 1 <= Experience.MAX_VIRT_LEVEL ? Experience.getXpForLevel(currentLevel + 1) : -1;
@@ -656,6 +659,7 @@ public class HiscorePanel extends PluginPanel
+ "</div>" + "</div>"
+ "</div>"; + "</div>";
} }
}
return openingTags + content + closingTags; return openingTags + content + closingTags;
} }