ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Improve performance of ClueScrollWorldMapPoint

Browse Source 
- Create the buffered image only once and not every time
ClueScrollWorldMapPoint is created
- Pass the world point directly to clue world map point constructor and
do it only once

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
This commit is contained in:
Tomas Slusny
2018-05-11 19:39:34 +02:00
parent bf9a019c2f
commit 37703ef8b6
2 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
runelite-client/src/main/java/net/runelite/client/plugins/cluescrolls/ClueScrollPlugin.java
View File

@@ -596,9 +596,8 @@ public class ClueScrollPlugin extends Plugin
{ {
if (worldMapPoint == null) if (worldMapPoint == null)
{ {
worldMapPoint = new ClueScrollWorldMapPoint(); worldMapPoint = new ClueScrollWorldMapPoint(point);
worldMapPointManager.add(worldMapPoint); worldMapPointManager.add(worldMapPoint);
} }
worldMapPoint.setWorldPoint(point);
} }
} }

40
runelite-client/src/main/java/net/runelite/client/plugins/cluescrolls/ClueScrollWorldMapPoint.java
View File

@@ -27,44 +27,46 @@ package net.runelite.client.plugins.cluescrolls;
import java.awt.Graphics; import java.awt.Graphics;
import java.awt.image.BufferedImage; import java.awt.image.BufferedImage;
import net.runelite.api.Point; import net.runelite.api.Point;
import net.runelite.api.coords.WorldPoint;
import net.runelite.client.ui.overlay.worldmap.WorldMapPoint; import net.runelite.client.ui.overlay.worldmap.WorldMapPoint;
class ClueScrollWorldMapPoint extends WorldMapPoint class ClueScrollWorldMapPoint extends WorldMapPoint
{ {
private final BufferedImage worldMapImage; private static final BufferedImage CLUE_SCROLL_WORLD_IMAGE;
private final Point imagePoint; private static final Point CLUE_SCROLL_WORLD_IMAGE_POINT;
private final BufferedImage edgeSnapImage;
ClueScrollWorldMapPoint() static
{ {
super(null, null); CLUE_SCROLL_WORLD_IMAGE = new BufferedImage(ClueScrollPlugin.MAP_ARROW.getWidth(), ClueScrollPlugin.MAP_ARROW.getHeight(), BufferedImage.TYPE_INT_ARGB);
Graphics graphics = CLUE_SCROLL_WORLD_IMAGE.getGraphics();
graphics.drawImage(ClueScrollPlugin.MAP_ARROW, 0, 0, null);
graphics.drawImage(ClueScrollPlugin.CLUE_SCROLL_IMAGE, 0, 2, null);
CLUE_SCROLL_WORLD_IMAGE_POINT = new Point(
CLUE_SCROLL_WORLD_IMAGE.getWidth() / 2,
CLUE_SCROLL_WORLD_IMAGE.getHeight());
}
ClueScrollWorldMapPoint(final WorldPoint worldPoint)
{
super(worldPoint, null);
this.setSnapToEdge(true); this.setSnapToEdge(true);
this.setJumpOnClick(true); this.setJumpOnClick(true);
this.setImage(CLUE_SCROLL_WORLD_IMAGE);
worldMapImage = new BufferedImage(ClueScrollPlugin.MAP_ARROW.getWidth(), ClueScrollPlugin.MAP_ARROW.getHeight(), BufferedImage.TYPE_INT_ARGB); this.setImagePoint(CLUE_SCROLL_WORLD_IMAGE_POINT);
Graphics graphics = worldMapImage.getGraphics();
graphics.drawImage(ClueScrollPlugin.MAP_ARROW, 0, 0, null);
graphics.drawImage(ClueScrollPlugin.CLUE_SCROLL_IMAGE, 0, 2, null);
imagePoint = new Point(worldMapImage.getWidth() / 2, worldMapImage.getHeight());
this.setImage(worldMapImage);
this.setImagePoint(imagePoint);
edgeSnapImage = ClueScrollPlugin.CLUE_SCROLL_IMAGE;
} }
@Override @Override
public void onEdgeSnap() public void onEdgeSnap()
{ {
this.setImage(edgeSnapImage); this.setImage(ClueScrollPlugin.CLUE_SCROLL_IMAGE);
this.setImagePoint(null); this.setImagePoint(null);
} }
@Override @Override
public void onEdgeUnsnap() public void onEdgeUnsnap()
{ {
this.setImage(worldMapImage); this.setImage(CLUE_SCROLL_WORLD_IMAGE);
this.setImagePoint(imagePoint); this.setImagePoint(CLUE_SCROLL_WORLD_IMAGE_POINT);
} }
} }