From 2d7adb248a29056c40ea308c5c540d02f1f3bb41 Mon Sep 17 00:00:00 2001 From: Adam Date: Mon, 30 Apr 2018 10:33:59 -0400 Subject: [PATCH] http-service: fix sql2o statement leak commit() will call closeJdbcConnection() which does not clean up statements and causes the later close() to noop --- .../main/java/net/runelite/http/service/item/ItemService.java | 4 ++-- .../main/java/net/runelite/http/service/xtea/XteaService.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/http-service/src/main/java/net/runelite/http/service/item/ItemService.java b/http-service/src/main/java/net/runelite/http/service/item/ItemService.java index 36f138ca3e..ff2fdbdb72 100644 --- a/http-service/src/main/java/net/runelite/http/service/item/ItemService.java +++ b/http-service/src/main/java/net/runelite/http/service/item/ItemService.java @@ -244,7 +244,7 @@ public class ItemService } query.executeBatch(); - con.commit(); + con.commit(false); return entries; } @@ -320,7 +320,7 @@ public class ItemService } q.executeBatch(); - con.commit(); + con.commit(false); } } diff --git a/http-service/src/main/java/net/runelite/http/service/xtea/XteaService.java b/http-service/src/main/java/net/runelite/http/service/xtea/XteaService.java index 60dd91ab44..ddc476a1fd 100644 --- a/http-service/src/main/java/net/runelite/http/service/xtea/XteaService.java +++ b/http-service/src/main/java/net/runelite/http/service/xtea/XteaService.java @@ -150,7 +150,7 @@ public class XteaService } query.executeBatch(); - con.commit(); + con.commit(false); } }