Merge pull request #10234 from Trevor159/raids-fix

raids plugin: fix rotation solver

runelite-client/src/main/java/net/runelite/client/plugins/raids/Raid.java

@@ -98,6 +98,25 @@ public class Raid
 		return combatRooms.toArray(new RaidRoom[0]);
 	}
 
+	void setCombatRooms(RaidRoom[] combatRooms)
+	{
+		int index = 0;
+
+		for (Room room : layout.getRooms())
+		{
+			if (room == null)
+			{
+				continue;
+			}
+
+			if (rooms[room.getPosition()].getType() == RoomType.COMBAT)
+			{
+				rooms[room.getPosition()] = combatRooms[index];
+				index++;
+			}
+		}
+	}
+
 	public String toCode()
 	{
 		StringBuilder builder = new StringBuilder();

runelite-client/src/main/java/net/runelite/client/plugins/raids/RaidsPlugin.java

@@ -320,7 +320,9 @@ public class RaidsPlugin extends Plugin
 				}
 
 				raid.updateLayout(layout);
-				RotationSolver.solve(raid.getCombatRooms());
+				RaidRoom[] rooms = raid.getCombatRooms();
+				RotationSolver.solve(rooms);
+				raid.setCombatRooms(rooms);
 				overlay.setScoutOverlayShown(true);
 
 				if (config.layoutMessage())

runelite-client/src/test/java/net/runelite/client/plugins/raids/RotationSolverTest.java

@@ -69,4 +69,12 @@ public class RotationSolverTest
 		RotationSolver.solve(rooms);
 		assertArrayEquals(new RaidRoom[]{VASA, SHAMANS, VESPULA, GUARDIANS}, rooms);
 	}
+
+	@Test
+	public void testSolve5()
+	{
+		RaidRoom[] rooms = new RaidRoom[]{GUARDIANS, UNKNOWN_COMBAT, SHAMANS, VASA};
+		RotationSolver.solve(rooms);
+		assertArrayEquals(new RaidRoom[]{GUARDIANS, VESPULA, SHAMANS, VASA}, rooms);
+	}
 }