diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/boosts/BoostIndicator.java b/runelite-client/src/main/java/net/runelite/client/plugins/boosts/BoostIndicator.java index 001e8ae5c8..ff286f409f 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/boosts/BoostIndicator.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/boosts/BoostIndicator.java @@ -32,7 +32,7 @@ import net.runelite.api.Skill; import net.runelite.client.ui.overlay.infobox.InfoBox; import net.runelite.client.ui.overlay.infobox.InfoBoxPriority; -public class BoostIndicator extends InfoBox +class BoostIndicator extends InfoBox { private final BoostsPlugin plugin; private final BoostsConfig config; @@ -87,7 +87,7 @@ public class BoostIndicator extends InfoBox @Override public boolean render() { - return config.displayInfoboxes() && plugin.canShowBoosts() && plugin.getSkillsToDisplay().contains(getSkill()); + return plugin.canShowBoosts() && plugin.getSkillsToDisplay().contains(getSkill()) && config.displayInfoboxes(); } @Override diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/boosts/BoostsOverlay.java b/runelite-client/src/main/java/net/runelite/client/plugins/boosts/BoostsOverlay.java index fd53503444..fff6408f2f 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/boosts/BoostsOverlay.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/boosts/BoostsOverlay.java @@ -61,13 +61,13 @@ class BoostsOverlay extends OverlayPanel @Override public Dimension render(Graphics2D graphics) { - if (config.displayInfoboxes()) + final Set boostedSkills = plugin.getSkillsToDisplay(); + if (boostedSkills.isEmpty() || !config.displayPanel()) { return null; } int nextChange = plugin.getChangeDownTicks(); - if (nextChange != -1) { panelComponent.getChildren().add(LineComponent.builder() @@ -77,7 +77,6 @@ class BoostsOverlay extends OverlayPanel } nextChange = plugin.getChangeUpTicks(); - if (nextChange != -1) { panelComponent.getChildren().add(LineComponent.builder() @@ -86,13 +85,6 @@ class BoostsOverlay extends OverlayPanel .build()); } - final Set boostedSkills = plugin.getSkillsToDisplay(); - - if (boostedSkills.isEmpty()) - { - return super.render(graphics); - } - if (plugin.canShowBoosts()) { for (Skill skill : boostedSkills) @@ -136,6 +128,5 @@ class BoostsOverlay extends OverlayPanel } return boost <= config.boostThreshold() ? Color.YELLOW : Color.GREEN; - } } diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/boosts/StatChangeIndicator.java b/runelite-client/src/main/java/net/runelite/client/plugins/boosts/StatChangeIndicator.java index 5c9ef73762..f93bae6086 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/boosts/StatChangeIndicator.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/boosts/StatChangeIndicator.java @@ -29,7 +29,7 @@ import java.awt.image.BufferedImage; import net.runelite.client.ui.overlay.infobox.InfoBox; import net.runelite.client.ui.overlay.infobox.InfoBoxPriority; -public class StatChangeIndicator extends InfoBox +class StatChangeIndicator extends InfoBox { private final boolean up; private final BoostsPlugin plugin; @@ -61,6 +61,6 @@ public class StatChangeIndicator extends InfoBox public boolean render() { final int time = up ? plugin.getChangeUpTicks() : plugin.getChangeDownTicks(); - return config.displayInfoboxes() && time != -1; + return time != -1 && config.displayInfoboxes(); } }