diff --git a/cache/src/main/java/net/runelite/cache/definitions/WorldMapTypeBase.java b/cache/src/main/java/net/runelite/cache/definitions/WorldMapTypeBase.java
index d24d6d63f3..3e5229f8f9 100644
--- a/cache/src/main/java/net/runelite/cache/definitions/WorldMapTypeBase.java
+++ b/cache/src/main/java/net/runelite/cache/definitions/WorldMapTypeBase.java
@@ -24,7 +24,4 @@
*/
package net.runelite.cache.definitions;
-public interface WorldMapTypeBase
-{
-
-}
+public interface WorldMapTypeBase {}
diff --git a/cache/src/main/java/net/runelite/cache/definitions/loaders/ItemLoader.java b/cache/src/main/java/net/runelite/cache/definitions/loaders/ItemLoader.java
index 6cb6c9bd41..806fa3eff8 100644
--- a/cache/src/main/java/net/runelite/cache/definitions/loaders/ItemLoader.java
+++ b/cache/src/main/java/net/runelite/cache/definitions/loaders/ItemLoader.java
@@ -25,13 +25,12 @@
package net.runelite.cache.definitions.loaders;
+import java.util.HashMap;
import net.runelite.cache.definitions.ItemDefinition;
import net.runelite.cache.io.InputStream;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.util.HashMap;
-
public class ItemLoader
{
private static final Logger logger = LoggerFactory.getLogger(ItemLoader.class);
@@ -40,7 +39,7 @@ public class ItemLoader
{
ItemDefinition def = new ItemDefinition(id);
InputStream is = new InputStream(b);
-
+
while (true)
{
int opcode = is.readUnsignedByte();
diff --git a/cache/src/test/java/net/runelite/cache/ModelDumperTest.java b/cache/src/test/java/net/runelite/cache/ModelDumperTest.java
index 32f5879ac1..bfd4bd9dba 100644
--- a/cache/src/test/java/net/runelite/cache/ModelDumperTest.java
+++ b/cache/src/test/java/net/runelite/cache/ModelDumperTest.java
@@ -25,7 +25,6 @@
package net.runelite.cache;
-
import com.google.common.io.Files;
import java.io.File;
import java.io.IOException;
diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index 6f6c6e65da..35ebf4519b 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -32,6 +32,8 @@
+
+
@@ -42,12 +44,12 @@
-
-
-
-
+
+
+
+
+
-
@@ -57,6 +59,11 @@
+
+
+
+
+
diff --git a/deobfuscator/src/main/java/net/runelite/asm/attributes/Annotations.java b/deobfuscator/src/main/java/net/runelite/asm/attributes/Annotations.java
index 7c1a6ba535..6e184a89ec 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/attributes/Annotations.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/attributes/Annotations.java
@@ -28,7 +28,6 @@ package net.runelite.asm.attributes;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
-
import net.runelite.asm.Type;
import net.runelite.asm.attributes.annotation.Annotation;
import net.runelite.asm.attributes.annotation.Element;
diff --git a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ArrayStoreInstruction.java b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ArrayStoreInstruction.java
index de019ce9e0..cf00821d10 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ArrayStoreInstruction.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ArrayStoreInstruction.java
@@ -25,7 +25,4 @@
package net.runelite.asm.attributes.code.instruction.types;
-public interface ArrayStoreInstruction extends MappableInstruction
-{
-
-}
+public interface ArrayStoreInstruction extends MappableInstruction {}
diff --git a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ComparisonInstruction.java b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ComparisonInstruction.java
index 25e0cdf1da..2076baeadc 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ComparisonInstruction.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ComparisonInstruction.java
@@ -25,7 +25,4 @@
package net.runelite.asm.attributes.code.instruction.types;
-public interface ComparisonInstruction
-{
-
-}
+public interface ComparisonInstruction {}
diff --git a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ConversionInstruction.java b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ConversionInstruction.java
index 099b281725..22b4977b71 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ConversionInstruction.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ConversionInstruction.java
@@ -25,7 +25,4 @@
package net.runelite.asm.attributes.code.instruction.types;
-public interface ConversionInstruction
-{
-
-}
+public interface ConversionInstruction {}
diff --git a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/GetFieldInstruction.java b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/GetFieldInstruction.java
index f5a5af480a..a9b7ab3cf3 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/GetFieldInstruction.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/GetFieldInstruction.java
@@ -25,6 +25,4 @@
package net.runelite.asm.attributes.code.instruction.types;
-public interface GetFieldInstruction extends FieldInstruction
-{
-}
+public interface GetFieldInstruction extends FieldInstruction {}
diff --git a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ReturnInstruction.java b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ReturnInstruction.java
index c23a0bdfb5..ce9a7e7d37 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ReturnInstruction.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/ReturnInstruction.java
@@ -25,7 +25,4 @@
package net.runelite.asm.attributes.code.instruction.types;
-public interface ReturnInstruction
-{
-
-}
+public interface ReturnInstruction {}
diff --git a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/SetFieldInstruction.java b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/SetFieldInstruction.java
index 7147d93047..0e645b01ee 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/SetFieldInstruction.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instruction/types/SetFieldInstruction.java
@@ -25,6 +25,4 @@
package net.runelite.asm.attributes.code.instruction.types;
-public interface SetFieldInstruction extends FieldInstruction, MappableInstruction
-{
-}
+public interface SetFieldInstruction extends FieldInstruction, MappableInstruction {}
diff --git a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instructions/InvokeStatic.java b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instructions/InvokeStatic.java
index 7d01d0d38c..bf85f47c95 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instructions/InvokeStatic.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/attributes/code/instructions/InvokeStatic.java
@@ -40,7 +40,6 @@ import net.runelite.asm.execution.InstructionContext;
import net.runelite.asm.execution.Stack;
import net.runelite.asm.execution.StackContext;
import static net.runelite.asm.execution.StaticStep.stepInto;
-
import net.runelite.asm.execution.Value;
import net.runelite.asm.pool.Method;
import net.runelite.asm.signature.Signature;
diff --git a/deobfuscator/src/main/java/net/runelite/asm/execution/Stack.java b/deobfuscator/src/main/java/net/runelite/asm/execution/Stack.java
index 2d0fa58ba9..fb01c7463a 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/execution/Stack.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/execution/Stack.java
@@ -25,11 +25,10 @@
package net.runelite.asm.execution;
-import net.runelite.asm.Type;
-
import java.util.Arrays;
import java.util.List;
import net.runelite.asm.Method;
+import net.runelite.asm.Type;
public class Stack
{
@@ -40,13 +39,13 @@ public class Stack
{
stack = new StackContext[sz * 2]; // XXX FIXME
}
-
+
public Stack(Stack other)
{
this.size = other.size;
this.stack = other.stack.clone();
}
-
+
private void printStack(StackContext ctx, int level)
{
for (int i = 0; i < level; ++i)
@@ -66,7 +65,7 @@ public class Stack
printStack(stack[c], 0);
throw new RuntimeException("Stack overflow");
}
-
+
assert !i.getType().equals(Type.VOID);
stack[size] = i;
@@ -80,12 +79,12 @@ public class Stack
return stack[--size];
}
-
+
public int getSize()
{
return size;
}
-
+
public List getStack()
{
return Arrays.asList(stack);
diff --git a/deobfuscator/src/main/java/net/runelite/asm/execution/VariableContext.java b/deobfuscator/src/main/java/net/runelite/asm/execution/VariableContext.java
index d1456737e5..56eabd3979 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/execution/VariableContext.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/execution/VariableContext.java
@@ -25,10 +25,9 @@
package net.runelite.asm.execution;
-import net.runelite.asm.Type;
-
import java.util.ArrayList;
import java.util.List;
+import net.runelite.asm.Type;
public class VariableContext
{
@@ -46,13 +45,13 @@ public class VariableContext
type = ctx.getType();
value = ctx.getValue();
}
-
+
public VariableContext(Type type) // for entrypoints
{
this.type = type;
value = Value.UNKNOWN;
}
-
+
public VariableContext(InstructionContext i, VariableContext other)
{
ic = i;
@@ -60,24 +59,24 @@ public class VariableContext
type = other.type;
value = other.value;
}
-
+
public VariableContext(InstructionContext i, Type type, Value value)
{
ic = i;
this.type = type;
this.value = value;
}
-
+
public StackContext getStackContext()
{
return ctx;
}
-
+
public InstructionContext getInstructionWhichStored()
{
return ic;
}
-
+
public Type getType()
{
return type;
@@ -87,7 +86,7 @@ public class VariableContext
{
return value;
}
-
+
public void addRead(InstructionContext ctx)
{
if (!read.contains(ctx))
@@ -103,7 +102,7 @@ public class VariableContext
{
return isParameter;
}
-
+
public VariableContext markParameter()
{
isParameter = true;
diff --git a/deobfuscator/src/main/java/net/runelite/asm/pool/Field.java b/deobfuscator/src/main/java/net/runelite/asm/pool/Field.java
index ca24bb33af..5eb4a5c663 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/pool/Field.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/pool/Field.java
@@ -25,9 +25,8 @@
package net.runelite.asm.pool;
-import net.runelite.asm.Type;
-
import java.util.Objects;
+import net.runelite.asm.Type;
public class Field
{
diff --git a/deobfuscator/src/main/java/net/runelite/asm/signature/Signature.java b/deobfuscator/src/main/java/net/runelite/asm/signature/Signature.java
index f3cd779eda..58b56deb2f 100644
--- a/deobfuscator/src/main/java/net/runelite/asm/signature/Signature.java
+++ b/deobfuscator/src/main/java/net/runelite/asm/signature/Signature.java
@@ -24,8 +24,6 @@
*/
package net.runelite.asm.signature;
-import net.runelite.asm.Type;
-
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
@@ -33,6 +31,7 @@ import java.util.List;
import java.util.Objects;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
+import net.runelite.asm.Type;
public class Signature
{
diff --git a/deobfuscator/src/main/java/net/runelite/deob/DeobAnnotations.java b/deobfuscator/src/main/java/net/runelite/deob/DeobAnnotations.java
index 6294574e74..d5e83313da 100644
--- a/deobfuscator/src/main/java/net/runelite/deob/DeobAnnotations.java
+++ b/deobfuscator/src/main/java/net/runelite/deob/DeobAnnotations.java
@@ -24,6 +24,7 @@
*/
package net.runelite.deob;
+import java.util.List;
import net.runelite.asm.ClassFile;
import net.runelite.asm.Field;
import net.runelite.asm.Method;
@@ -33,8 +34,6 @@ import net.runelite.asm.attributes.annotation.Annotation;
import net.runelite.asm.attributes.annotation.Element;
import net.runelite.asm.signature.Signature;
-import java.util.List;
-
public class DeobAnnotations
{
public static final Type OBFUSCATED_NAME = new Type("Lnet/runelite/mapping/ObfuscatedName;");
diff --git a/deobfuscator/src/main/java/net/runelite/deob/deobfuscators/RenameUnique.java b/deobfuscator/src/main/java/net/runelite/deob/deobfuscators/RenameUnique.java
index 1f1789afb5..06c6e905ea 100644
--- a/deobfuscator/src/main/java/net/runelite/deob/deobfuscators/RenameUnique.java
+++ b/deobfuscator/src/main/java/net/runelite/deob/deobfuscators/RenameUnique.java
@@ -25,6 +25,7 @@
package net.runelite.deob.deobfuscators;
+import java.util.List;
import net.runelite.asm.ClassFile;
import net.runelite.asm.ClassGroup;
import net.runelite.asm.Field;
@@ -35,31 +36,29 @@ import net.runelite.deob.DeobAnnotations;
import net.runelite.deob.Deobfuscator;
import net.runelite.deob.util.NameMappings;
-import java.util.List;
-
public class RenameUnique implements Deobfuscator
{
private Renamer renamer;
-
+
private void generateClassNames(NameMappings map, ClassGroup group)
{
int i = 0;
-
+
for (ClassFile cf : group.getClasses())
{
if (cf.getName().length() > Deob.OBFUSCATED_NAME_MAX_LEN)
{
continue;
}
-
+
map.map(cf.getPoolClass(), "class" + i++);
}
}
-
+
private void generateFieldNames(NameMappings map, ClassGroup group)
{
int i = 0;
-
+
for (ClassFile cf : group.getClasses())
for (Field field : cf.getFields())
{
@@ -67,7 +66,7 @@ public class RenameUnique implements Deobfuscator
{
continue;
}
-
+
map.map(field.getPoolField(), "field" + i++);
}
}
@@ -75,7 +74,7 @@ public class RenameUnique implements Deobfuscator
private void generateMethodNames(NameMappings map, ClassGroup group)
{
int i = 0;
-
+
for (ClassFile cf : group.getClasses())
for (Method method : cf.getMethods())
{
@@ -83,16 +82,16 @@ public class RenameUnique implements Deobfuscator
{
continue;
}
-
+
List virtualMethods = VirtualMethods.getVirtualMethods(method);
assert !virtualMethods.isEmpty();
-
+
String name;
if (virtualMethods.size() == 1)
name = "method" + i++;
else
name = "vmethod" + i++;
-
+
for (Method m : virtualMethods)
map.map(m.getPoolMethod(), name);
}
@@ -103,13 +102,13 @@ public class RenameUnique implements Deobfuscator
{
group.buildClassGraph();
group.lookup();
-
+
NameMappings mappings = new NameMappings();
-
+
this.generateClassNames(mappings, group);
this.generateFieldNames(mappings, group);
this.generateMethodNames(mappings, group);
-
+
renamer = new Renamer(mappings);
renamer.run(group);
}
diff --git a/deobfuscator/src/main/java/net/runelite/deob/deobfuscators/packethandler/PacketRead.java b/deobfuscator/src/main/java/net/runelite/deob/deobfuscators/packethandler/PacketRead.java
index 18da7bc11d..8faf63dc0a 100644
--- a/deobfuscator/src/main/java/net/runelite/deob/deobfuscators/packethandler/PacketRead.java
+++ b/deobfuscator/src/main/java/net/runelite/deob/deobfuscators/packethandler/PacketRead.java
@@ -25,7 +25,6 @@
package net.runelite.deob.deobfuscators.packethandler;
import java.util.Objects;
-
import net.runelite.asm.Type;
import net.runelite.asm.attributes.code.Instruction;
import net.runelite.asm.execution.InstructionContext;
diff --git a/deobfuscator/src/main/java/net/runelite/gamepack/Downloader.java b/deobfuscator/src/main/java/net/runelite/gamepack/Downloader.java
index 350454ac8b..221ba4b4c6 100644
--- a/deobfuscator/src/main/java/net/runelite/gamepack/Downloader.java
+++ b/deobfuscator/src/main/java/net/runelite/gamepack/Downloader.java
@@ -1,6 +1,5 @@
package net.runelite.gamepack;
-
import java.io.File;
import java.io.IOException;
import java.net.URL;
diff --git a/deobfuscator/src/test/java/net/runelite/deob/deobfuscators/unusedclass/EmptyClass.java b/deobfuscator/src/test/java/net/runelite/deob/deobfuscators/unusedclass/EmptyClass.java
index 371b55daf9..1d3ba8614b 100644
--- a/deobfuscator/src/test/java/net/runelite/deob/deobfuscators/unusedclass/EmptyClass.java
+++ b/deobfuscator/src/test/java/net/runelite/deob/deobfuscators/unusedclass/EmptyClass.java
@@ -24,7 +24,4 @@
*/
package net.runelite.deob.deobfuscators.unusedclass;
-public class EmptyClass
-{
-
-}
+public class EmptyClass {}
diff --git a/deobfuscator/src/test/java/net/runelite/deob/deobfuscators/unusedclass/EmptyInterface.java b/deobfuscator/src/test/java/net/runelite/deob/deobfuscators/unusedclass/EmptyInterface.java
index ffcb0a3188..4f7214f5b0 100644
--- a/deobfuscator/src/test/java/net/runelite/deob/deobfuscators/unusedclass/EmptyInterface.java
+++ b/deobfuscator/src/test/java/net/runelite/deob/deobfuscators/unusedclass/EmptyInterface.java
@@ -24,7 +24,4 @@
*/
package net.runelite.deob.deobfuscators.unusedclass;
-public interface EmptyInterface
-{
-
-}
+public interface EmptyInterface {}
diff --git a/deobfuscator/src/test/java/net/runelite/osb/HookImporter.java b/deobfuscator/src/test/java/net/runelite/osb/HookImporter.java
index dbb17bfe55..ac178bfa7b 100644
--- a/deobfuscator/src/test/java/net/runelite/osb/HookImporter.java
+++ b/deobfuscator/src/test/java/net/runelite/osb/HookImporter.java
@@ -70,9 +70,7 @@ public class HookImporter
Assert.assertNotNull(is);
Gson gson = new Gson();
- java.lang.reflect.Type type = new TypeToken