ra/runelite
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Merge pull request #2453 from open-osrs/revert-2451-upupandaway

Browse Source 
Revert "upstream: merge"
This commit is contained in:
Kyle
2020-03-23 17:38:49 +00:00
committed by GitHub
parent da8b03a927 ab93ecba36
commit 0a3ebca541
4 changed files with 4 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
runelite-api/src/main/java/net/runelite/api/Client.java
View File

@@ -1817,11 +1817,6 @@ public interface Client extends GameShell
* Get the item index of the item being dragged on an if1 widget * Get the item index of the item being dragged on an if1 widget
*/ */
int getIf1DraggedItemIndex(); int getIf1DraggedItemIndex();
/**
* If a widget is in target mode?
*/
boolean getSpellSelected();
/** /**
* Sets if a widget is in target mode * Sets if a widget is in target mode

17
runelite-client/src/main/java/net/runelite/client/input/MouseManager.java
View File

@@ -33,9 +33,6 @@ import javax.inject.Singleton;
@Singleton @Singleton
public class MouseManager public class MouseManager
{ {
// Button numbers greater than BUTTON3 have no constant identifier
private static final int MOUSE_BUTTON_4 = 4;
private final List<MouseListener> mouseListeners = new CopyOnWriteArrayList<>(); private final List<MouseListener> mouseListeners = new CopyOnWriteArrayList<>();
private final List<MouseWheelListener> mouseWheelListeners = new CopyOnWriteArrayList<>(); private final List<MouseWheelListener> mouseWheelListeners = new CopyOnWriteArrayList<>();
@@ -77,7 +74,6 @@ public class MouseManager
public MouseEvent processMousePressed(MouseEvent mouseEvent) public MouseEvent processMousePressed(MouseEvent mouseEvent)
{ {
checkExtraMouseButtons(mouseEvent);
for (MouseListener mouseListener : mouseListeners) for (MouseListener mouseListener : mouseListeners)
{ {
mouseEvent = mouseListener.mousePressed(mouseEvent); mouseEvent = mouseListener.mousePressed(mouseEvent);
@@ -87,7 +83,6 @@ public class MouseManager
public MouseEvent processMouseReleased(MouseEvent mouseEvent) public MouseEvent processMouseReleased(MouseEvent mouseEvent)
{ {
checkExtraMouseButtons(mouseEvent);
for (MouseListener mouseListener : mouseListeners) for (MouseListener mouseListener : mouseListeners)
{ {
mouseEvent = mouseListener.mouseReleased(mouseEvent); mouseEvent = mouseListener.mouseReleased(mouseEvent);
@@ -97,7 +92,6 @@ public class MouseManager
public MouseEvent processMouseClicked(MouseEvent mouseEvent) public MouseEvent processMouseClicked(MouseEvent mouseEvent)
{ {
checkExtraMouseButtons(mouseEvent);
for (MouseListener mouseListener : mouseListeners) for (MouseListener mouseListener : mouseListeners)
{ {
mouseEvent = mouseListener.mouseClicked(mouseEvent); mouseEvent = mouseListener.mouseClicked(mouseEvent);
@@ -105,17 +99,6 @@ public class MouseManager
return mouseEvent; return mouseEvent;
} }
private void checkExtraMouseButtons(MouseEvent mouseEvent)
{
// Prevent extra mouse buttins from being passed into the client,
// as it treats them all as left click
int button = mouseEvent.getButton();
if (button >= MOUSE_BUTTON_4)
{
mouseEvent.consume();
}
}
public MouseEvent processMouseEntered(MouseEvent mouseEvent) public MouseEvent processMouseEntered(MouseEvent mouseEvent)
{ {
for (MouseListener mouseListener : mouseListeners) for (MouseListener mouseListener : mouseListeners)

4
runelite-client/src/main/java/net/runelite/client/ui/overlay/Overlay.java
View File

@@ -69,8 +69,4 @@ public abstract class Overlay implements LayoutableRenderableEntity
{ {
return this.getClass().getSimpleName(); return this.getClass().getSimpleName();
} }
public void onMouseOver()
{
}
} }

13
runelite-client/src/main/java/net/runelite/client/ui/overlay/OverlayRenderer.java
View File

@@ -235,7 +235,7 @@ public class OverlayRenderer extends MouseAdapter implements KeyListener
if (!isResizeable) if (!isResizeable)
{ {
// On fixed mode, ABOVE_CHATBOX_RIGHT is in the same location as // On fixed mode, ABOVE_CHATBOX_RIGHT is in the same location as
// BOTTOM_RIGHT and CANVAS_TOP_RIGHT is same as TOP_RIGHT. // BOTTOM_RIGHT and CANVAST_TOP_RIGHT is same as TOP_RIGHT.
// Just use BOTTOM_RIGHT and TOP_RIGHT to prevent overlays from // Just use BOTTOM_RIGHT and TOP_RIGHT to prevent overlays from
// drawing over each other. // drawing over each other.
switch (overlayPosition) switch (overlayPosition)
@@ -316,14 +316,9 @@ public class OverlayRenderer extends MouseAdapter implements KeyListener
graphics.setColor(previous); graphics.setColor(previous);
} }
if (!client.isMenuOpen() && !client.getSpellSelected() && bounds.contains(mouse)) if (menuEntries == null && !client.isMenuOpen() && !client.isSpellSelected() && bounds.contains(mouse))
{ {
if (menuEntries == null) menuEntries = createRightClickMenuEntries(overlay);
{
menuEntries = createRightClickMenuEntries(overlay);
}
overlay.onMouseOver();
} }
} }
} }
@@ -639,4 +634,4 @@ public class OverlayRenderer extends MouseAdapter implements KeyListener
return entries; return entries;
} }
} }