From 074f1e0841bfa7ed4aa86c137c4da5d14ccd4dcc Mon Sep 17 00:00:00 2001 From: Max Weber Date: Fri, 11 Jun 2021 03:18:35 -0600 Subject: [PATCH] client: correctly use Runnables::doNothing passing it as a method reference complete defeats the point of the method as it desugars to: option("foo", () -> { Runnable unused = Runnables.doNothing(); }); --- .../runelite/client/plugins/banktags/tabs/TabInterface.java | 2 +- .../client/plugins/chatchannel/ChatChannelPlugin.java | 2 +- .../plugins/groundmarkers/GroundMarkerSharingManager.java | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java index 0564d7b38b..0846efdf43 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java @@ -447,7 +447,7 @@ public class TabInterface }) ) .option("2. Only tab", () -> clientThread.invoke(() -> deleteTab(target))) - .option("3. Cancel", Runnables::doNothing) + .option("3. Cancel", Runnables.doNothing()) .build(); break; case Tab.EXPORT_TAB: diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/chatchannel/ChatChannelPlugin.java b/runelite-client/src/main/java/net/runelite/client/plugins/chatchannel/ChatChannelPlugin.java index 308af21d5b..d58fa8ad27 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/chatchannel/ChatChannelPlugin.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/chatchannel/ChatChannelPlugin.java @@ -809,7 +809,7 @@ public class ChatChannelPlugin extends Plugin kickConfirmed = false; }) ) - .option("2. Cancel", Runnables::doNothing) + .option("2. Cancel", Runnables.doNothing()) .build(); } diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/groundmarkers/GroundMarkerSharingManager.java b/runelite-client/src/main/java/net/runelite/client/plugins/groundmarkers/GroundMarkerSharingManager.java index 056ed509f2..ff4be28f8a 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/groundmarkers/GroundMarkerSharingManager.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/groundmarkers/GroundMarkerSharingManager.java @@ -202,7 +202,7 @@ class GroundMarkerSharingManager chatboxPanelManager.openTextMenuInput("Are you sure you want to import " + importPoints.size() + " ground markers?") .option("Yes", () -> importGroundMarkers(importPoints)) - .option("No", Runnables::doNothing) + .option("No", Runnables.doNothing()) .build(); } @@ -275,7 +275,7 @@ class GroundMarkerSharingManager + (numActivePoints == 1 ? " was cleared." : "s were cleared.")); }) - .option("No", Runnables::doNothing) + .option("No", Runnables.doNothing()) .build(); }