From 81b8d2f664b5b6c5dfc418f11b5a1bcf19cbbcb7 Mon Sep 17 00:00:00 2001 From: Tomas Slusny Date: Fri, 13 Apr 2018 16:04:58 +0200 Subject: [PATCH] Do not reuse HttpUrl.builder for building xp urls Due to HttpUrl.Builder being mutable, this causes duplicate URL path segments when tracking more than 1 skill at a time. Signed-off-by: Tomas Slusny --- .../runelite/client/plugins/xptracker/XpPanel.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/xptracker/XpPanel.java b/runelite-client/src/main/java/net/runelite/client/plugins/xptracker/XpPanel.java index fa6798b2af..7e41095bba 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/xptracker/XpPanel.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/xptracker/XpPanel.java @@ -49,12 +49,6 @@ import okhttp3.HttpUrl; @Slf4j class XpPanel extends PluginPanel { - private static final HttpUrl.Builder XP_TRACKER_FORMAT = new HttpUrl.Builder() - .scheme("https") - .host("runelite.net") - .addPathSegment("xp") - .addPathSegment("show"); - private final Map infoBoxes = new HashMap<>(); private final JLabel totalXpGained = new JLabel(); private final JLabel totalXpHr = new JLabel(); @@ -120,7 +114,11 @@ class XpPanel extends PluginPanel return ""; } - return XP_TRACKER_FORMAT + return new HttpUrl.Builder() + .scheme("https") + .host("runelite.net") + .addPathSegment("xp") + .addPathSegment("show") .addPathSegment(skill.getName().toLowerCase()) .addPathSegment(player.getName()) .addPathSegment("1week")